Sql insert query failed

Question

0.00/5 (No votes)

See more:

Hello Friends, I have a requirement to create a new table from three tables as the sources. Table1 will act as a master table where all the other data tables (Table2 and Table 3) need to be gathered. I also need to add a date as the source for trending.
The below insert command is getting failed

INSERT INTO newtable  
(
  [Todaydate],
	[Name],
	[LOCATION],
	[Type],
)
VALUES
(
( 
SELECT GETDATE()
),
(
SELECT t1.Name, t2.Location, t3.Type
  from table1 t1
  LEFT JOIN table2 t2
  ON t1.Name=t2.Name
  LEFT JOIN table3 t3
  ON t1.Name=t3.Name
)
)

ERROR:
Only one expression can be specified in the select list when the subquery is not introduced with EXISTS.
The multi-part identifier "Name" could not be bound.
There are more columns in the INSERT statement than values specified in the VALUES clause. The number of values in the VALUES clause must match the number of columns specified in the INSERT statement.

Please help. Thank you

What I have tried:

The SQL query has been changed but no luck

Posted 11-Mar-21 6:08am

Laksh1983

Updated 11-Mar-21 6:16am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

NotTodayYo · Answer 1 · 2021-03-11T06:16:00

Solution 1

Your syntax is wrong. You have all kinds of extra characters.

Keep it simple:

SQL

INSERT INTO newtable ([Todaydate], [Name],[LOCATION], [Type])
SELECT GETDATE(), t1.Name, t2.Location, t3.Type
from table1 t1
LEFT JOIN table2 t2 ON t1.Name=t2.Name
LEFT JOIN table3 t3 ON t1.Name=t3.Name

Posted 11-Mar-21 6:16am

NotTodayYo

Comments

Maciej Los 12-Mar-21 1:52am

5ed!

Richard Deeming · Answer 2 · 2021-03-11T06:16:00

That is not a valid INSERT query.
INSERT (Transact-SQL) - SQL Server | Microsoft Docs[^]

SQL

INSERT INTO newtable  
(
    [Todaydate],
	[Name],
	[LOCATION],
	[Type]
)
SELECT 
    GETDATE(),
    t1.Name, 
    t2.Location, 
    t3.Type
FROM
    table1 t1
    LEFT JOIN table2 t2
    ON t1.Name=t2.Name
    LEFT JOIN table3 t3
    ON t1.Name=t3.Name
;