Combobox selected value is not displaying

Question

0.00/5 (No votes)

See more:

I have created a WPF Application on Localization.The page contain one dropdown and one label . Dropdown contain different languages. I need to change culture of the label text as per the selection. I have added .resx file for all languages. Every thing is working fine except the dropdown selected value is not displaying.

What I have tried:

This is MainWindow.xaml

<Grid>
        <Label Content="{x:Static Resources:Resources.textBox}" HorizontalAlignment="Left" Margin="194,100,0,0"   VerticalAlignment="Top" Width="283" Height="23" Name="textBox"/>
        <ComboBox HorizontalAlignment="Left" Margin="194,179,0,0" VerticalAlignment="Top" Width="283" Height="36" SelectionChanged="ComboBox_SelectionChanged"  Name="cmName">
            
            <ComboBoxItem IsSelected="True" Content="English"></ComboBoxItem>
            <ComboBoxItem Content="Hindi"></ComboBoxItem>
            <ComboBoxItem Content="Odia"></ComboBoxItem>
            
        </ComboBox>
        
    </Grid>

This is MainWindow.xaml.cs

public partial class MainWindow : Window
    {
        public MainWindow()
        {
            InitializeComponent();
        }
      

        private void ComboBox_SelectionChanged(object sender, SelectionChangedEventArgs e)
        {

            if ((ComboBoxItem)cmName.SelectedItem != null)
            {
                string s = null;
                ComboBoxItem cbi = (ComboBoxItem)cmName.SelectedItem;
                if (cbi.Content != null)
                {
                    s = cbi.Content.ToString();
                }

                if (s == "Hindi")
                {
                  

                    App.ChangeCulture(new CultureInfo("hi-IN"));

                }
                else if (s == "Odia")
                {
                    App.ChangeCulture(new CultureInfo("or-IN"));
                }
                else if (s == "English")
                {
                    App.ChangeCulture(new CultureInfo("en-US"));
                }
                else
                {
                }


            }
        }
 
        

        
    }

This is in App.xaml.cs

public partial class App : Application
    {
       
       
        public static void ChangeCulture(CultureInfo newCulture)
        {
            Thread.CurrentThread.CurrentCulture = newCulture;
            Thread.CurrentThread.CurrentUICulture = newCulture;

            var oldWindow = Application.Current.MainWindow;

            Application.Current.MainWindow = new MainWindow();
            Application.Current.MainWindow.Show();
            oldWindow.Close();
        }
    }

Posted 17-May-21 23:17pm

Gita Padhihari

Updated 18-May-21 5:33am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tony Hill · Accepted Answer · 2021-05-18T03:18:00

That is because when you have selected a different language you call your ChangeCulture method in App.xaml.cs which then creates a new MainWindow for the application that replaces the current MainWindow which is then discarded when the method finishes.

The old MainWindow is the one that knows which item in the combobox was selected, the new MainWindow would initialise the combobox to point to the first item as it knows nothing about the old MainWindow or what you did in it.

George Swan · Accepted Answer · 2021-05-18T05:33:00

Tony is quite correct in his answer. I would suggest that you simplify your solution by having an ObservableCollection of a simple class as follows.

C#

public class Culture
  {
      public string Id { get; set; }
      public string Name { get; set; }
  }
public ObservableCollection<Culture> CultureList { get; set; } = new()
  {
    new Culture() { Name = "English", Id = "en-US" },
    new Culture() { Name = "Hindi", Id = "hi-IN" },
    new Culture() { Name = "Odia", Id = "or-IN" }
  };
//add a SelectedCulture property
public Culture SelectedCulture { get; set; }

Next, bind the ComboBox to both the collection and the SelectedCulture property in the xaml. Also in the xaml, subscribe to the Window Loaded event and the ComboBox SelectionChanged event.

C#

Title="MainWindow" Height="450" Width="800" Loaded="Window_Loaded">
<Grid>
  <TextBlock Name="CultureTB"  HorizontalAlignment="Left" Margin="194,100,0,0"   VerticalAlignment="Top" Width="283"   Height="23" />
  <ComboBox HorizontalAlignment="Left" Margin="194,179,0,0" VerticalAlignment="Top" Width="283" Height="36"     SelectionChanged="ComboBox_SelectionChanged" Name="CultureComboBox"
            ItemsSource="{Binding Path=CultureList}"
            DisplayMemberPath="Name"
            SelectedItem="{Binding Path=SelectedCulture}" />
</Grid>

In the code behind, handle the two events and call a SetCulture method to change the culture.

C#

private void ComboBox_SelectionChanged(object sender, SelectionChangedEventArgs e)
{
    var combo = sender as ComboBox;
    if (combo != null)
    {
        Culture culture = (Culture)combo.SelectedValue;
        CultureTB.Text = culture.Name;
        SetCulture(culture.Id);
    }

}
private void SetCulture(string cultureName)
{
    Thread.CurrentThread.CurrentCulture = new CultureInfo(cultureName);
    Thread.CurrentThread.CurrentUICulture = new CultureInfo(cultureName);
}

private void Window_Loaded(object sender, RoutedEventArgs e)
{
    DataContext = this;
    var culture = CultureList[0];
    SelectedCulture = culture;
}

Combobox selected value is not displaying

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0