Managing (printing) a vector of strings inside a function (C)

Question

0.00/5 (No votes)

See more:

I am having trouble managing a array of strings.
This program is supposed to ask 3 names and then ask for a new name to rewrite the 1st name it got.
Then I print inside the function "change" the names[1] and names[2] which print incorrectly.
Finnaly at the End I print the 3 names without problems.

C

#include <stdio.h>
#include <string.h>

void change(char *names){
    printf("Insert New Name1: ");
    scanf("%s",&names[4]);
    strcpy(&names[0],&names[4]);
    printf("Test: %s\n",&names[1]);
    printf("Test: %s",&names[2]);
}

void main(void){
    char names[25][80];
    printf("Name 1: ");
    scanf("%s",&names[0]);
    printf("Name 2: ");
    scanf("%s",&names[1]);
    printf("Name 3: ");
    scanf("%s",&names[2]);
    change(names);
    printf("\nName1: %s",names[0]);
    printf("\nName2: %s",names[1]);
    printf("\nName3: %s",names[2]);
}

Terminal

Name 1: Jhon
Name 2: Wick
Name 3: Snow
Insert New Name1: John
Test: ohn
Test: hn
Name1: John
Name2: Wick
Name3: Snow
Process returned 12 (0xC)   execution time : 27.781 s
Press any key to continue.

What I have tried:

I tried to remove the "&" from the printfs but it crash.

Posted 23-Nov-21 12:14pm

kingu399

Updated 23-Nov-21 13:21pm

Rick York

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Rick York · Answer 1 · 2021-11-23T13:21:00

The problem is the change function is not set up correctly. It needs to know the length of the strings. Your code accepted a single character pointer instead of an array of strings.

One way to do this is to define a type like this:

C

#define NAME_LENGTH 79

typedef char   NameString[ NAME_LENGTH+1 ];

void change( NameString names[] )
{
    printf( "Insert New Name1: " );
    scanf( "%s", names[4] );
    strcpy( names[0], names[4] );
    printf( "Test 1: %s\n", names[1] );
    printf( "Test 2: %s\n", names[2] );
}

void main(void)
{
    NameString names[25];
    printf("Name 1: ");
    scanf("%s", names[0] );
    printf("Name 2: ");
    scanf("%s", names[1] );
    printf("Name 3: ");
    scanf("%s", names[2] );

    change( names );

    printf("Name 1: %s\n", names[0]);
    printf("Name 2: %s\n", names[1]);
    printf("Name 3: %s\n", names[2]);
}