Click here to Skip to main content
15,890,670 members
Please Sign up or sign in to vote.
0.00/5 (No votes)
See more:
Hello, when I run this, nothing happens, there seems to be an infinite stalling somewhere and I can't find what's going wrong.


public static int[] getIntArrayFromUser(int numNums)
	    {
	    	
	    	int count = 0;
	    	int [] newArray = new int[numNums];

	    	while (count != numNums);
	    	{
		    	System.out.print("Enter next integer: ");
		    	newArray[count] = (input.nextInt());
		    	count ++;
	    	}
	    	return newArray;
	    }

		    	
	    		
	    	
	    
	    static void problem6()
	    {
	    	int numNums = 6;
	    	int[] newArray = getIntArrayFromUser(numNums);
	    	for (int num : newArray)
	    	{
	    		System.out.println(num);
	    	}
	    }


What I have tried:

I haven't a clue what to do here, I don't see where things are going wrong.
Posted
Updated 6-Feb-22 13:32pm

I changed a little bit in your code:
public static void main(String[] args) {
    int numNums = 6;
    int[] newArray = getIntArrayFromUser(numNums);
    for (int num : newArray)
    {
        System.out.println(num);
    }
}



public static int[] getIntArrayFromUser(int numNums)
{

    int count = 0;
    int [] newArray = new int[numNums];
    Scanner scanner = new Scanner(System.in);
    while (count != numNums)
    {
        System.out.print("Enter next integer: ");
        newArray[count] = scanner.nextInt();
        count ++;
    }
    scanner.close();
    return newArray;
}

The change I did is that I used Scanner class to get the user input and I noticed that you have a semicolon after the while condition you wrote:
while (count != numNums);

which will perform an endless loop, maybe this is what caused the program to not show anything because it stuck in the while loop.
 
Share this answer
 
v2
Comments
Grelm 7-Feb-22 12:34pm    
Thanks! I already have the Scanner class called upon earlier in the code. It was the semicolon lol.
Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
 
Share this answer
 
Comments
Grelm 6-Feb-22 18:12pm    
My problem is that my code does nothing, and I don't know why. So I can't get an idea of what's going wrong because nothing is being outputted to the console.
OriginalGriff 7-Feb-22 2:42am    
That's *why* you use the debugger - it lets you look at your code while it is running and see which route it is taking and what data it is working with.
Grelm 7-Feb-22 12:32pm    
Oh, alright, thank you.
OriginalGriff 7-Feb-22 12:36pm    
You're welcome!

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900