Why this code isn't working?

Question

1.00/5 (2 votes)

See more:

I keep getting these errors

test2.cpp|27|error: expected unqualified-id before '.' token|  
test2.cpp|28|error: expected unqualified-id before '.' token|  
test2.cpp|29|error: expected unqualified-id before '.' token|  
test2.cpp|33|error: expected primary-expression before '.' token|  
test2.cpp|34|error: expected primary-expression before '.' token|  
test2.cpp|35|error: expected unqualified-id before '.' token|  
test2.cpp|41|error: expected primary-expression before '.' token|  
test2.cpp|42|error: expected primary-expression before '.' token|  
test2.cpp|43|error: expected primary-expression before '.' token|  
test2.cpp|44|error: expected primary-expression before '.' token|

#include <iostream>
#include <string>
#include <vector>

using namespace std;

class Movies;

class Movie{

    static vector<string> name;
    static vector<string> rating;
    static vector<int> watched;
    friend class Movies;

};

vector<string> Movie::name;
vector<string> Movie::rating;
vector<int> Movie::watched;

class Movies{

public :

    void add(string n, string r, int w){
        Movie.name.push_back(n);
        Movie.rating.push_back(r);
        Movie.watched.push_back(w);
    }

    void inc_watched(string n){
        auto it = Movie.name.find(n);
        int x = Movie.watched.begin() - it;
        Movie.watched[x]++;
    }

    void display(){
        cout << "        MOVIES       " << endl;
        cout << "=====================" << endl;
        for(size_t x(); x<Movie.name.size(); x++){
            cout << "NAME : " << Movie.name[x] << endl;
            cout << "RATING: " << Movie.rating[x] << endl;
            cout << "WATCHED : " << Movie.watched[x] << " Times" << endl;
        }
    }
};

int main(){

    Movies m;
    m.add("Movie1", "G", 1);
    m.add("Movie2", "PG", 2);
    m.add("Movie3", "PG-13", 3);
    m.add("Movie4", "R", 4);
    m.display();
    m.inc_watched("Movie1");
    m.inc_watched("Movie1");
    m.inc_watched("Movie1");
    m.inc_watched("Movie1");
    m.display();

}

What I have tried:

I tried putting declaration in different header files for class Movie and Movies and their implementation in .cpp but it didn't work.

Posted 7-Mar-22 0:55am

Bruh FC

Updated 7-Mar-22 1:19am

Add a Solution

Comments

Richard MacCutchan 7-Mar-22 7:06am

Inside your Movies class you are trying to refer to Movie as an object, but it is a class. Your Movies class should be making a vector of individual Movie items, rather than the way you are trying to do it. You need to rethink your design.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2022-03-07T01:19:00

You should use the :: operator to access static members of a class.
The following code compiles (please note your code is anyway not-so-well designed).

If you wish to see a more C++-oriented approach, have a look at the update section below the code.

C++

#include <iostream>
#include <string>
#include <vector>

using namespace std;

class Movies;

class Movie{
public:
    static vector<string> name;
    static vector<string> rating;
    static vector<int> watched;
    friend class Movies;

};

vector<string> Movie::name;
vector<string> Movie::rating;
vector<int> Movie::watched;

class Movies{

public :

    void add(string n, string r, int w){
        Movie::name.push_back(n);
        Movie::rating.push_back(r);
        Movie::watched.push_back(w);
    }

    void inc_watched(string s)
    {

        for (size_t n=0; n<Movie::name.size(); ++n)
          if ( Movie::name[n] == s)
          {
            Movie::watched[n]++;
            break;
          }
    }

    void display(){
        cout << "        MOVIES       " << endl;
        cout << "=====================" << endl;
        for(size_t x; x<Movie::name.size(); x++){
            cout << "NAME : " << Movie::name[x] << endl;
            cout << "RATING: " << Movie::rating[x] << endl;
            cout << "WATCHED : " << Movie::watched[x] << " Times" << endl;
        }
    }
};

int main(){

    Movies m;
    m.add("Movie1", "G", 1);
    m.add("Movie2", "PG", 2);
    m.add("Movie3", "PG-13", 3);
    m.add("Movie4", "R", 4);
    m.display();
    m.inc_watched("Movie1");
    m.inc_watched("Movie1");
    m.inc_watched("Movie1");
    m.inc_watched("Movie1");
    m.display();

}

[update]
A more C++-oriented approach

C++"

include <string>
#include <vector>
#include <algorithm>
using namespace std;

class Movie
{
  string m_name, m_rating;
  int m_watched_count;

public:
    Movie( string name, string rating, int watched_count ): m_name(name), m_rating(rating), m_watched_count(watched_count){}

    string get_name() const { return m_name; };
    void inc_watched(){ ++m_watched_count; }

    friend ostream &  operator << (ostream & os, const Movie &  movie);

};

ostream &  operator << (ostream & os, const Movie & movie)
{
    os << "NAME : " << movie.m_name << "\n";
    os <<"RATING: " << movie.m_rating << "\n";
    os << "WATCHED : " << movie.m_watched_count << " Times" << "\n";
    return os;
}


void display_movies( const vector<Movie> & movie_vect )
{
    cout << "        MOVIES       \n";
    cout << "=====================\n";
    for ( const auto & movie : movie_vect)
      cout << movie  << "---------------------\n";
}

int main()
{

    vector <Movie> mv;

    mv.push_back(Movie{"Movie1", "G", 1});
    mv.push_back(Movie{"Movie2", "PG", 2});
    mv.push_back(Movie{"Movie3", "PG-13", 3});
    mv.push_back({"Movie4", "R", 4});
    display_movies(mv);

    auto it = find_if(mv.begin(), mv.end(), [](const Movie & m){ return (m.get_name() == "Movie1");});

    if ( it != mv.end())
    {
      it->inc_watched();
      it->inc_watched();
      it->inc_watched();
      it->inc_watched();
    }

    display_movies(mv);
}

[/update]

Greg Utas · Accepted Answer · 2022-03-07T01:03:00

They are static variables, so you'd have to access them as Movie::<member>. However, a static variable in a class means that there's only one instance of it in the entire program, not an instance per object. I think you want to remove the static keyword and the initializations that follow the definition of your class, at least if you want to handle more than one Movie.

In looking at this more closely, you're using a separate static vector for each attribute of a Movie. That could work, but it's not how it's done in C++. Movie shouldn't have any static members, although you could have a global Movies vector to keep track of each individual Movie.

Why this code isn't working?

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0