Index was outside the bounds of the array.

Question

1.00/5 (1 vote)

See more:

static void lineChanger(string newText, string fileName, int line_to_edit)
        {
            string[] arrLine = File.ReadAllLines(fileName);
            arrLine[line_to_edit - 1] = newText;
            File.WriteAllLines(fileName, arrLine);
        }

lineChanger(textBox5.Text, "C:\\Users\\x\\Documents\\Random.txt", counter);
            lineChanger(textBox1.Text, "C:\\Users\\x\\Documents\\Random.txt", counter + 1);
            lineChanger(textBox2.Text, "C:\\Users\\x\\Documents\\Random.txt", counter + 2);
            lineChanger(textBox3.Text, "C:\\Users\\x\\Documents\\Random.txt", counter + 3);

I get the error "

Index was outside the bounds of the array.

" when trying to edit a line.

What I have tried:

I've tried changing the array from -1 but to no affect

Posted 13-Mar-22 6:50am

Minecraft Graphix

Updated 13-Mar-22 8:09am

Add a Solution

Comments

Richard MacCutchan 13-Mar-22 12:53pm

Which file are you processing, how many lines does it contain and what is the value of counter when the error occurs?

Maciej Los 13-Mar-22 13:55pm

What value counter variable holds?

PIEBALDconsult 14-Mar-22 1:00am

You may also prefer to use verbatim strings for file paths.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Answer 1 · 2022-03-13T08:09:00

The reason is quite obvious. See updated procedure.

C#

static void lineChanger(string newText, string fileName, int line_to_edit)
{
    string[] arrLine = File.ReadAllLines(fileName);
	Console.WriteLine($"arrLine.Length: {arrLine.Length}\tline_to_edit: {line_to_edit}");
    if(line_to_edit < 0 || line_to_edit > arrLine.Length-1)
		{
			Console.WriteLine($"Note: line to edit ({line_to_edit}) is bigger than number of lines ({arrLine.Length}) in file or less than 0");
			return;
		}
	arrLine[line_to_edit] = newText;
    File.WriteAllLines(fileName, arrLine);
}

BTW:
Do not use "C:\\Users\\x\\Documents\\Random.txt" several times. Create and use a variable, for example:

C#

string sFile = "C:\\Users\\x\\Documents\\Random.txt";
//then
lineChanger(textBox5.Text, sFile, counter);