C# - doubts on ternary operator. (? ; )

Question

0.00/5 (No votes)

See more:

Hi all, I have this code with ternary operator (not easy to maintenance).

C#

d_reg_f = (entity.d_fot == DateTime.MinValue ? (xreg_f == null ? DateTime.MinValue : reg_f.d_registrazione) : entity.d_fot != DateTime.MinValue && reg_f.d_cre > entity.d_fot ? DateTime.MinValue :  reg_f.d_cre <= entity.d_fot ? reg_f.d_registrazione : DateTime.MinValue);

What I have tried:

I converted the code like this

C#

if (entity.d_fot == DateTime.MinValue)
      if (xreg_f == null)
                { d_reg_f = DateTime.MinValue; }
                else
                { d_reg_f = reg_f.d_registrazione; }
            else if (entity.d_fot != DateTime.MinValue && reg_f.d_cre > entity.d_fot)
            { d_reg_f = DateTime.MinValue; }
            else if (reg_f.d_cre <= entity.d_fot)
            { d_reg_f = reg_f.d_registrazione; }
            else
            { d_reg_f = DateTime.MinValue; }

It seems to work fine but I'm not sure.
Did I forget something in the If? What do you think?
Thanks to those who will answer me.

Posted 18-Jun-22 23:16pm

antobaro

Updated 19-Jun-22 0:48am

RickZeeland

v2

Add a Solution

Comments

0x01AA 19-Jun-22 6:46am

I found this: Ternary to If-else online converter[^]
Maybe it helps you to verify your code.

2 solutions

Solution 1

Using this tool: Ternary to If-else online converter[^]
I get this:

if (entity.d_fot == DateTime.MinValue) {
	if (xreg_f == null) {
		d_reg_f= DateTime.MinValue;
	} else {
		d_reg_f= reg_f.d_registrazione;
	}
} else {
	if (entity.d_fot != DateTime.MinValue && reg_f.d_cre > entity.d_fot) {
		d_reg_f= DateTime.MinValue;
	} else {
		if (reg_f.d_cre <= entity.d_fot) {
			d_reg_f= reg_f.d_registrazione;
		} else {
			d_reg_f= DateTime.MinValue;
		}
	}
}

Posted 19-Jun-22 0:47am

0x01AA

Updated 19-Jun-22 1:25am

v4

Comments

Graeme_Grant 19-Jun-22 6:58am

check the lack of value assignment

0x01AA 19-Jun-22 7:02am

Yes I'm aware of that. But it should show only the logic. OP seems to have enough knowledge to complete it ;)

0x01AA 19-Jun-22 7:15am

there you go ... cleaner solution

Graeme_Grant 19-Jun-22 7:20am

5'd ... but you missed one... :P

0x01AA 19-Jun-22 7:26am

Thanks :-)

0x01AA 19-Jun-22 11:24am

OFYI: Then I thought I'm clever and made a console application with some ternary operators and disassembled them back to c# with IlSpy and also .net reflector.
No sucess, both of them disassmble them into ternary operators :-)

antobaro 19-Jun-22 11:33am

Thank you very much

0x01AA 19-Jun-22 12:53pm

Take care on that. I'm pretty sure the above is right (cross checked it) ;)

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Graeme_Grant · Accepted Answer · 2022-06-19T00:48:00

Readability comes down to formatting:

1. Ternary:

C#

d_reg_f = (entity.d_fot == DateTime.MinValue
    ? (xreg_f == null
        ? DateTime.MinValue
        : reg_f.d_registrazione)
    : entity.d_fot != DateTime.MinValue && reg_f.d_cre > entity.d_fot
       ? DateTime.MinValue
       : reg_f.d_cre <= entity.d_fot
           ? reg_f.d_registrazione
           : DateTime.MinValue
    );

2. if ... else if ... else with Ternary

C#

if (entity.d_fot == DateTime.MinValue)
{
    d_reg_f = xreg_f == null
        ? DateTime.MinValue
        : reg_f.d_registrazione;
}
else if (entity.d_fot != DateTime.MinValue && reg_f.d_cre > entity.d_fot)
{
    d_reg_f = reg_f.d_cre <= entity.d_fot
        ? reg_f.d_registrazione
        : DateTime.MinValue;
}
else
{
    d_reg_f = DateTime.MinValue;
}