Click here to Skip to main content
15,887,746 members
Please Sign up or sign in to vote.
1.00/5 (2 votes)
See more:
Possibly your code does not work correctly for multiple test-cases (TCs).
The first test case where your code failed

This is what comes up...

What I have tried:

#include <stdio.h>

int main()
{
    int n, j;
    int arr[4], i;
    n = 4;
    printf(""); // enter the number of test cases:
    scanf("%d", &j);
    printf(""); // enter the size of array:
    scanf("%d", &n);
    for (i = 0; i < 4; i++)
    {
        printf(""); // enter the   elements of array
        scanf("%d", &arr[i]);
    }
    // for (i = 0; i < 4; i++)
    // {
    //     printf("%d ", arr[i]);
    // }
    for (i = 4; i >=0; i--)
    {
        printf("%d ", arr[i]); // the reverse of the array elements will be
    }

    return 0;
}
Posted
Updated 24-Aug-22 1:42am
Comments
Richard MacCutchan 24-Aug-22 5:19am    
See below.

Why do you do:
C++
printf(""); // enter the number of test cases:

instead of
C++
printf("enter the number of test cases: ");

?

And since you only have 4 array elements, the range is 0..3, so
C++
for (i = 4; i >=0; i--)

should be
C++
for (i = 3; i >=0; i--) // index 3 is the highest element
 
Share this answer
 
Comments
CPallini 24-Aug-22 5:53am    
5.
We have no access to yoru test cases, or even any idea what your code is supposed to do - and both of those are needed to even start working out what the problem is.

But ... Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
C
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
 
Share this answer
 
Quote:
Stuck with this C code

In C, arrays are zero based !
C++
int arr[4], i;

This means that your array of size 4 uses indices from 0 to 3.
error should be obvious:
C++
for (i = 4; i >=0; i--)
{
    printf("%d ", arr[i]); // the reverse of the array elements will be
}
 
Share this answer
 
Try
C
#include <stdio.h>
  
enum
{
  MaxArraySize = 4,
};

int main()
{
  int n;
  int arr[MaxArraySize];

  printf("enter the size of array: ");
  scanf("%d", &n);

  if ( n > MaxArraySize)
  {
    fprintf(stderr, "invalid array size\n");
    return -1;
  }

  for (int i = 0; i < n; ++i)
  {
    printf(" enter the element  %d of array ", i);
    scanf("%d", &arr[i]);
  }

  for (int i = 0; i < n; ++i)
  {
    int r = n-1-i; // 'reverse index' 
    printf("%d ", arr[r]); // the reverse of the array elements will be
  }

  return 0;
}
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900