How do I create a vector wich element are lines of a txt file

Question

0.00/5 (No votes)

See more:

Hello, I've created a txt file (c++ language) and then try to copy his element in a vector so that each element of the vector is a line of the file. But at the end when i try to display the elements of the vector, there are voids elements but i don't know how to remove them.

What I have tried:

C++

ifstream sjp2("L2.txt");
while(getline(sjp2,s))
L2.push_back(s);

Posted 1-Sep-22 7:20am

Shalom Kamokoue

Updated 2-Sep-22 1:29am

Add a Solution

Comments

CPallini 1-Sep-22 14:04pm

Your code looks correct. However, without knowing the exact input data, it is difficult to give help.

Richard MacCutchan 1-Sep-22 14:11pm

Check that each line actually contains some text before you add it to the vector.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Greg Utas · Accepted Answer · 2022-09-02T01:29:00

(I originally submitted this as a comment in Solution 1, but it wouldn't format properly.)

The easiest way to avoid empty strings in the vector is not to put them there in the first place:

C++

while(getline(sjp2,s))
{
   if(!s.empty() && (s.back() == '\r')) s.pop_back();
   if(!s.empty()) L2.push_back(s);
}

That pop_back line is in case the file you're reading was created on Windows but is being read on Linux. Windows adds "\r\n" at the end of a line, whereas Linux only adds '\n'. It is therefore necessary to strip out the '\r'. You can remove that line unless you need to handle that scenario.

Rick York · Accepted Answer · 2022-09-01T08:09:00

You have not shown what type the variables L2 or s are so I will guess s is of type std::string and L2 is a std::vector< std::string >. With those guesses, your code appears to be correct. To write there are "voids" elements makes no sense - what does "voids" mean? You might have empty strings in vector but that is likely to be because of empty lines in the text file. Again, I can only guess because I can't see the text file or what your output looks like. YOU need to make that comparison and see if it makes sense.

With a bit more information I could probably be more helpful.

How do I create a vector wich element are lines of a txt file

2 solutions

Solution 2

Solution 1

Add your solution here

Preview 0

Existing Members

...or Join us