Delete multiple rows from access database using datagridview C#

Question

1.00/5 (1 vote)

See more:

Hello everyone.
I have an Access table "Print" that I load into my program using dataGridView6.
I want to remove all selected rows in dataGridView6 and Assess table with one click.
I am asking for your help. Thank you.

What I have tried:

private void Button1_Click(object sender, EventArgs e)
       {
           for (int i = 0; i < dataGridView6.SelectedRows.Count; i++)
           {
               string query = "Delete From Print Where Id=@id";
               cmd = new OleDbCommand(query, con);
               cmd.Parameters.AddWithValue("@id", dataGridView6.SelectedRows[i].Cells[0].Value);
               con.Open();
               cmd.ExecuteNonQuery();
               con.Close();
           }
       }

Posted 19-Jan-23 7:48am

Member 10410972

Updated 19-Jan-23 8:48am

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Dave Kreskowiak · Accepted Answer · 2023-01-19T08:48:00

Your code is creating a multitude of objects it doesn't need to create. Get the query setup and parameter out of the loop and setup the connection so it only has to be opened once. You also have to dispose your connection object when you're done with it. That is easily done with a using statement:

C#

using (OleDbConnection con = new OldDbConnection(...connection string...))
{
    string query = "DELETE FROM Print WHERE Id=@id";
    OleDbCommand cmd = new OldDbCommand(query, con);
    OleDbParameter idParam = new OleDbParameter("@id", OleDbType.Integer);    // Or whatever your Id type is...
    cmd.Parameters.Add(idParam);

    con.Open();

    for (int i = 0; i < dataGridView6.SelectedRows.Count; i++)
    {
        idParam.Value = dataGridView6.SelectedRows[i].Cells[0].Value;
        cmd.ExecuteNonQuery();
    }
}