Remove duplicate character from my string ?

Question

0.00/5 (No votes)

See more:

I am getting same char output multiple times JAVA

input - Shubham
output - hh

I want my output -
only - h

Here is my code -

What I have tried:

Scanner sc = new Scanner(System.in);
System.out.println("Enter the string ??");
String str = sc.nextLine();
str=str.toLowerCase();
char[] st = str.toCharArray();
System.out.println(Arrays.toString(st));
int count = 0;
for(int i=0;i<str.length();i++) {
    for(int j=i+1;i<str.length();i++) {
        if(st[i]==st[j]) {
            count+=1;
            }
        if(count>0) {
            System.out.print(st[i]);
            count=0;
            }
        }
    }

Posted 1-Apr-23 22:52pm

Shubham Guha_1007_IMCA1

Updated 1-Apr-23 23:25pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2023-04-01T23:25:00

Consider using else if instead of if:

I'd simplify that code:
Create an array of 26 integers, preset it to all zeros - call it letterCounts
Loop through your input string once, for each character, if it's between 'a' and 'z' inclusive, increment the appropriate element of letterCounts

After the loop, add a second loop which checks letterCounts - all values which are two or more indicate duplicates so print the appropriate letter.

This means you aren't looping through potentially long strings N² times which is what your code is doing, as well as getting rid of your problem. Instead, you make N passes through your loop, plus 26 through the counts.