C bool function, need help with repairs

Question

0.00/5 (No votes)

See more:

I have written a function which takes as parameters the beginning of the list, a hint(A,B,C,D) and the number of the question. Its task is to decide if I guessed the correct answer correctly. However, combined with the back working of the program, I think something may have gone wrong

bool helyesValasz(Adatok *eleje, char tipp, int kerdes) {
    Adatok *jelenlegi = eleje;

    for (int i = 1; i < kerdes && jelenlegi != NULL; i++) {
        jelenlegi = jelenlegi->kovetkezo;
    }

    if (jelenlegi == NULL) {
        return false; 
    }
    return (toupper(tipp) == toupper(jelenlegi->valasz));
}

What I have tried:

I have tested a lot, tried to debug but couldnt.

Posted 25-Nov-23 9:55am

420bela

Updated 25-Nov-23 21:45pm

KarstenK

v2

Add a Solution

Comments

Mike Hankey 25-Nov-23 16:18pm

The code looks like it ought to work, what is it doing that is wrong?

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2023-11-26T20:06:00

I guess it should be

C++

bool helyesValasz(Adatok *eleje, char tipp, int kerdes) 
{
    Adatok *jelenlegi = eleje;

    for (int i = 1; i < kerdes && jelenlegi != NULL; i++) 
    {
        if ( (toupper(tipp) == toupper(jelenlegi->valasz) )
        {
            return true; // foud
        }

        jelenlegi = jelenlegi->kovetkezo;
    }
    return false; 
}

merano99 · Answer 2 · 2023-11-25T12:25:00

If it is a C program, you would need a special header for the declaration of bool. Alternatively, you could use the data type directly in C++. The program seems to meet the requirement exactly. Even if we take into account the parts already known from the other questions, the function is correct.

With the implementation of kerdes, I am a little unsure whether the comparison with the index i would be reliable enough. Perhaps it would be better if a number from the Adatok structure were compared instead of the loop index i. Either would work, depending on what you want.

KarstenK · Answer 3 · 2023-11-25T21:51:00

Solution 2

It would be better to use english names because me (as a german) dont understand your "kovetkezo". Now you are stepping with that linked element. Maybe it is used as "before" pointer.
As merano99 wrote without the "Adatok" and it usage it is only guessing.

Posted 25-Nov-23 21:51pm

KarstenK

C bool function, need help with repairs

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0