Low time complexity in linked list deletion?

Question

1.00/5 (1 vote)

See more:

Hi, Actually i tried to code for the low time complexity in linked list deletion, but can't able to find out the logic for that. can u help me??

whole iteration logic i know but i need low complexity logic help me furthur...

What I have tried:

C++

#include<iostream>
using namespace std;

void Deletion(Mynode** p_node, int p_Val)
{
     if(*p_node == NULL)                    return ;

     Mynode* tmp = *p_node, prev = *p_node;
     while(tmp != NULL)
     {
          if(tmp->val == p_Val)
          {
              //some miss logic will be there, i need less iteration.
              prev->m_Next = tmp->m_Next;
              delete tmp;
              return ;
          }
          prev = tmp;
          tmp = tmp->m_Next;
     }
}

Posted 6-Dec-23 5:17am

mathiv327

Updated 6-Dec-23 6:10am

Rick York

v2

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

merano99 · Accepted Answer · 2023-12-06T13:35:00

At the beginning of the function you should make sure that p_node is not a nullptr before the pointer is used. Checking for nullptr at the beginning could avoid unexpected errors. There is still a problem in this source code if the first element is to be deleted. A correction would be necessary here.

Is there more information about the data? Are the elements sorted and can elements be contained more than once?

Only the first element found with the specified value is deleted here. If the value occurs more than once in the list and all occurrences are to be deleted, the loop would have to be continued after one occurrence is deleted.

Special knowledge about the distribution of the values could possibly lead to optimizations.

The time complexity of the Deletion function above depends on the number of elements in the linked list. If the list is run through to find the element to be deleted or all random occurrences of it, it is a linear search. Thus, it must be assumed that in the worst case, the entire list must be run through to find the element to be deleted or all random occurrences of it. Overall, the average and worst time complexity of the current implementation could be O(n).