Runtime error on larger number test cases

Question

1.00/5 (1 vote)

See more:

Here is my complete code

C++

<pre>#include <iostream>
#include <string>
using namespace std;

int main() {
    int T;
    cin >> T;
    while(T--)
    {
        string str;
        cin >> str;
        int index=-1;
        for(int i=1;i<str.size();++i)
        {
            if(str[i]!='0')
            {
                index=i+1;
                break;
            }
        }
        string a=str.substr(0,index-1);
        string b=str.substr(index-1);
        int str_a=stoi(a);
        int str_b=stoi(b);
        if(str_b>str_a)
        {
            cout << str_a << " " << str_b << endl;
        }
        else
        {
            cout << "-1" << endl;
        }
    }

    return 0;
}

What I have tried:

If I test on 5 test cases then its fine, when I test on 1000 test cases then it says "Exit code is 3, runtime error". Why it says like that? What's the reason behind it's? How can I fix this issue?

Posted 4-Feb-24 2:11am

md sohagr

Add a Solution

Comments

Richard MacCutchan 4-Feb-24 8:59am

You have not explained what data you are passing in for your tests or what results you expect to see. Without more information it is impossible to guess where it fails, or why.

md sohagr 4-Feb-24 9:10am

If I input 1000 test cases then it says 'run time error'.

Richard MacCutchan 4-Feb-24 11:26am

You cannot expect us to guess what data you feed in for those 1000 test cases. Also, it is difficult to work out what this code is supposed to be doing.

CPallini 5-Feb-24 2:14am

You provided the code but failed to provide the 'problem description' as well as 'input' and 'expected output'.

jeron1 5-Feb-24 10:22am

What if the string only contains zero's? "000" for example.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2024-02-04T02:16:00

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:

Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16

Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:

C#

private int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using the debugger to find out why. Put a breakpoint on the first line of the method, and run your app. When it reaches the breakpoint, the debugger will stop, and hand control over to you. You can now run your code line-by-line (called "single stepping") and look at (or even change) variable contents as necessary (heck, you can even change the code and try again if you need to).
Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
Hopefully, that should help you locate which part of that code has a problem, and what the problem is.
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

k5054 · Answer 2 · 2024-02-04T05:43:00

Solution 2

Some things to check:
1) what happens if there's no '0' in the input string?
2) what happens if the string that you're passing to stoi() is larger than INT_MAX?

Posted 4-Feb-24 5:43am

k5054

Comments

Richard MacCutchan 4-Feb-24 12:19pm

I built that code and all it seems to do is split a numeric string at the first non-zero digit.