Getting Syntax Error in Update Statement

Question

2.00/5 (1 vote)

See more:

hi!! i am getting Syntax Error in Update Statement

the values are provided by clicking a cell in datagridview...

SQL

OleDbCommand cmd = new OleDbCommand("update from Purchases SET '" + name_of_column + "' ="  + new_val + " WHERE '" + name_of_column + "' ="  + cellvalue, con);

can someone please help me with this...

Thanks in Advance.. :)

Posted 24-Feb-13 3:20am

Member 7849477

Add a Solution

3 solutions

Solution 1

"from" is not used in "UPDATE" statement.

OleDbCommand cmd = new OleDbCommand("Update Purchases SET '" + name_of_column + "' ="  + new_val + " WHERE '" + name_of_column + "' ="  + cellvalue, con);

The way you are concatenating user input instead of using OleDbParameter class leaves your program susceptible to SQL Injection Attack. Using an SQL Injection Attack, a nefarious individual could erase or damage your database.

Posted 24-Feb-13 3:26am

Mike Meinz

Solution 2

i think u dont need to put the word from in the commandString
i.e. ur command was:

OleDbCommand cmd = new OleDbCommand("update from Purchases SET '" + name_of_column + "' ="  + new_val + " WHERE '" + name_of_column + "' ="  + cellvalue, con);

but it must be

OleDbCommand cmd = new OleDbCommand("update Purchases SET '" + name_of_column + "' ="  + new_val + " WHERE '" + name_of_column + "' ="  + cellvalue, con);

Posted 24-Feb-13 3:26am

bunzitop

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Shanu2rick · Accepted Answer · 2013-02-24T03:29:00

The reason behind this syntax error is in your upadate query. you are passing your table name as a string value with single quotes and the value without single quotes.
Rewrite your code like this:

C#

OleDbCommand cmd = new OleDbCommand("update Purchases SET " + name_of_column + " ='"  + new_val + "' WHERE " + name_of_column + " = '"  + cellvalue + "', con);