Syntax error in update statement

Question

4.33/5 (2 votes)

See more:

I am using ms access as a database and getting error in update statement.
Can somebody help me out.?

C#

String userid = username.Text;
                 String password = pwd.Text;
                String date1=date12.Text;
                String report1 = report.Text;
                 OleDbConnection conn = new OleDbConnection(@"Provider=Microsoft.ACE.OLEDB.12.0;Data Source=C:\Users\divyapc\My Documents\CRPDatabase.accdb;
     Jet OLEDB:Database Password=divya6");
                 MessageBox.Show(userid);
                 OleDbCommand cmmd = new OleDbCommand("UPDATE trialtable SET userid=@userid, password = @password,testreport= @testreport,date12= @date12 where userid = @userid)", conn);
                 cmmd.Parameters.Add("@USERID", OleDbType.VarChar).Value = userid;
                 cmmd.Parameters.Add("@PASSWORD", OleDbType.VarChar).Value = password;
                 cmmd.Parameters.Add("@TESTREPORT", OleDbType.VarChar).Value = report1;
                 cmmd.Parameters.Add("@DATE12", OleDbType.VarChar).Value = date1;
                 conn.Open();

                  int temp = cmmd.ExecuteNonQuery();
                     if (temp > 0)
                     {
                         username.Text = null;
                         pwd.Text = null;
                         MessageBox.Show("Record Successfuly updated");
                     }
                     else
                     {
                         MessageBox.Show("Record Fail to Added");
                     }

                     conn.Close();
                 }

Posted 17-Feb-14 0:15am

Diya Bh.

Updated 17-Feb-14 0:16am

Krunal Rohit

v2

Add a Solution

Comments

Krunal Rohit 17-Feb-14 6:16am

what error ?

Diya Bh. 17-Feb-14 6:19am

syntax error in update statement

R-a-v-i-k-u-m-a-r 17-Feb-14 6:17am

What error you are getting?

5 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Answer 1 · 2014-02-17T00:23:00

Solution 3

Solution 1 seems a good start.

Moreover, if userid column in your database is primary key, I doubt you will be able to update it.

Maybe you can try:

C#

OleDbCommand cmmd = new OleDbCommand("UPDATE trialtable SET password = @password, testreport = @testreport, date12 = @date12 where userid = @userid", conn);

Hope this helps.

Posted 17-Feb-14 0:23am

phil.o

v3

Comments

Diya Bh. 17-Feb-14 6:25am

its just the trial page for update statement.

Krunal Rohit · Answer 2 · 2014-02-17T00:19:00

Solution 1

There might be error in your naming conventions of you query parameters. Use following one instead,

SQL

cmmd.Parameters.Add("@userid", OleDbType.VarChar).Value = userid;
cmmd.Parameters.Add("@password", OleDbType.VarChar).Value = password;
cmmd.Parameters.Add("@testreport", OleDbType.VarChar).Value = report1;
cmmd.Parameters.Add("@date12", OleDbType.VarChar).Value = date1;

-KR

Posted 17-Feb-14 0:19am

Krunal Rohit

Comments

Diya Bh. 17-Feb-14 6:21am

again it is giving the same error.

Krunal Rohit 17-Feb-14 6:23am

remove one bracket, which is at end of your query.
-KR

Diya Bh. 17-Feb-14 6:26am

I removed ...but still the same error.

Krunal Rohit 17-Feb-14 6:27am

can you paste the error here ?

Diya Bh. · Answer 3 · 2014-02-17T00:40:00

here is the solution:

String userid = username.Text;
                String password = pwd.Text;
               String date1=date12.Text;
               String report1 = report.Text;
                OleDbConnection conn = new OleDbConnection(@"Provider=Microsoft.ACE.OLEDB.12.0;Data Source=C:\Users\divyapc\My Documents\CRPDatabase.accdb;
    Jet OLEDB:Database Password=divya6");
                MessageBox.Show(userid);
                OleDbCommand cmmd = new OleDbCommand("UPDATE trialtable SET userid=@userid, [password] = @password,testreport= @report1,date12= @date1 where userid = @userid");
                cmmd.Parameters.Add("@USERID", OleDbType.VarChar).Value = userid;
                cmmd.Parameters.Add("@PASSWORD", OleDbType.VarChar).Value = password;
                cmmd.Parameters.Add("@TESTREPORT", OleDbType.VarChar).Value = report1;
                cmmd.Parameters.Add("@DATE12", OleDbType.VarChar).Value = date1;
                conn.Open();
                cmmd.Connection = conn;

                 int temp = cmmd.ExecuteNonQuery();
                    if (temp > 0)
                    {
                        username.Text = null;
                        pwd.Text = null;
                        MessageBox.Show("Record Successfuly updated");
                    }
                    else
                    {
                        MessageBox.Show("Record Fail to Added");
                    }

                    conn.Close();
                }

Prabhat *Spark* · Answer 4 · 2014-02-17T00:21:00

Solution 2

there's an unnecessary bracket before the double quotes at

...@userid)"

i.e: it should be

@userid"

Posted 17-Feb-14 0:21am

Prabhat Spark

Comments

Diya Bh. 17-Feb-14 6:23am

still the same error..

King Fisher · Answer 5 · 2014-02-17T00:46:00

SQL

OleDbCommand cmmd = new OleDbCommand("UPDATE trialtable SET userid=@userid, password = @password,testreport= @testreport,date12= @date12 where userid = @userid)", conn);

Error in your query stmt

SQL

OleDbCommand cmmd = new OleDbCommand("UPDATE trialtable SET userid=@userid, password = @password,testreport= @testreport,date12= @date12 where userid = @userid", conn);

Syntax error in update statement

5 solutions

Solution 3

Solution 1

Solution 5

Solution 2

Solution 6

Add your solution here

Preview 0