Strings Assignment in C#

Question

0.00/5 (No votes)

See more:

Hello,

Can anyone please tell me what is the mistake in it.

C#

string Stat;

                    if (fsensorvalue1 >= 05 &&  fsensorvalue1 <=29)
                    {

                        Stat = "Normal";

                    }

                    else if ( fsensorvalue1 >= 30 && fsensorvalue1 <= 34)

                    {
                        Stat = " Critical";

                    }

Posted 27-Feb-13 0:45am

ontheline89

Add a Solution

Comments

Azziet 27-Feb-13 6:51am

what is fsensorvalue1 ?

CHill60 27-Feb-13 6:52am

Use the Improve question link to post the error message or compiler warning you got

Chris Reynolds (UK) 27-Feb-13 6:54am

What do you think is wrong? You haven't said what is happening that is unexpected. I can see a problem if fsensorvalue1 is a float as a value of 29.5 will fall between the two ifs.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-02-27T00:52:00

Probably, the compiler is complaining about "Use of unassigned local variable 'Stat'" because there is a code path where Stat does not receive a value: when fsensorvalue1 is less than or greater than 34. This may not be possible in the wider context of your code, but the compiler will still complain about it.

Just change the definition line:

C#

string Stat = "Undefined";

and it will go away.

Jegan Thiyagesan · Accepted Answer · 2013-02-27T00:56:00

Hi,
There are couple of things in your code,

First: The string variable "State" is not initialized.

Second: The conditions are between range 4 and 35, so if the sensor value was beyond this range the "Stat" variable will not be used, so you will get an unused variable warning.

Have you considered this:

C#

string Stat = "";
if (fsensorvalue1 > 4 &&  fsensorvalue1 < 30)
{
    Stat = "Normal";
}

else if ( fsensorvalue1 > 29 && fsensorvalue1 < 35)
{
    Stat = "Critical";
}
else
{
   Stat = "Sensor Value '" + fsensorvalue1.ToString() + "' out of range.";
}

Regards
Jegan

CHill60 · Accepted Answer · 2013-02-27T01:02:00

Solution 3

OR...

If the compiler is returning an error similar to
Error 1 Operator '>=' cannot be applied to operands of type 'System.Windows.Forms.TextBox' and 'int'

then you need to use the value of the textbox (or combobox or whatever you've used), converted to an int e.g.

C#

string Stat;
int i;

int.TryParse(fsensorvalue1.Text, out i);

if (i >= 05 &&  i <=29)
{
    Stat = "Normal";
}
else if ( i >= 30 && i <= 34)
{
    Stat = " Critical";
}

Posted 27-Feb-13 1:02am

CHill60

Comments

ontheline89 27-Feb-13 23:29pm

Thank you so much for your answers.

CHill60 28-Feb-13 4:31am

You're welcome. I'm curious though ... which error was it?

ontheline89 28-Feb-13 9:00am

thanks .... it was saying, Unused Variable !

Strings Assignment in C#

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0