is it a correct query ?

Question

1.00/5 (1 vote)

See more:

is it a correct query ?

("UPDATE LOGIN u ,SlideShowTable s SET u.U_Email = '" + txtU_Email.Text + "',s.ImageName='" + txtImageName.Text + "',s.Description='" + txtDescription.Text + "',s.ADshop_name='" + txtADshop_name.Text + "',s.ADShop_Address='" + txtADShop_Address.Text + "',s.ADshop_city='" + txtADshop_city.Text + "',s.ADshop_mob='" + txtADshop_mob.Text + "',s.ADshop_Email='" + txtADshop_Email.Text + "' where s.UserId and u.UserId= " + userid, con);

Posted 11-Mar-13 20:13pm

Amirsalgar1

Add a Solution

Comments

bbirajdar 12-Mar-13 3:00am

no

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2013-03-11T21:01:00

Sorry, I'm not going to check it for correctness. (It actually depends on what is do you have in UI.) The whole idea is so wrong and dangerous, so your code should not be considered. You should never compose a query by concatenating strings, especially taken from UI. Just think about it: a text input can contain anything, including… fragment of SQL code.

This opens doors to a well-known exploit called SQL injection. Please see my past answers explaining it, with explanation of what you should do:
hi name is not displaying in name?[^],
EROR IN UPATE in com.ExecuteNonQuery();[^].

This is a great example: http://xkcd.com/327/[^].

This is not the only problem. You demonstrate the trend to work with string representation of data instead of data itself. This is very bad.

Good luck,

—SA