To Show List in MVC 4

Question

0.00/5 (No votes)

See more:

foreach statement cannot operate on variables of type 'demo.mvc.Models.Book' because 'demo.mvc.Models.Book' does not contain a public definition for 'GetEnumerator'

Iam Getting This Error
Please solve this
Here is my code:

ASP

csHtml:
@{
    ViewBag.Title = "Index";
}
@model demo.mvc.Models.Book
<h2>
    Index</h2>
@*<form action ="@Url.Action()" method="post">
</form>*@
@Html.ValidationSummary(true)
@Html.BeginForm()
<fieldset>
    <fieldset>
        <table>
            <tr>
                @*<th>
                    BookId
                </th>*@
                <th>
                    @Html.DisplayNameFor(model => model.Name)
                </th>
                <td>
                    @Html.DisplayNameFor(model => model.Author)
                </td>
            </tr>
            @foreach (var item in Model)
            {
                <tr>
                    @*<td>
                    @Html.DisplayFor(model => model.BookId)
                </td>*@
                    <td>
                        @Html.DisplayFor(modelItem => modelItem.Name)
                    </td>
                    <td>
                        @Html.DisplayFor(modelItem => modelItem.Author)
                    </td>
                </tr>
            }
        </table>
    </fieldset>
   
</fieldset>

Controller:

C#

public ActionResult Index()
       {
           List<Book> bk = new List<Book>();
           SqlConnection con = new SqlConnection(@"data source=192.168.1.2\SqlSrv08Dev;DataBase=sa;user id=sa;pwd=1234;Application Name=MVC");
           con.Open();
           string query = "select * from Book ";
           SqlCommand cmd = new SqlCommand(query, con);
           SqlDataAdapter da = new SqlDataAdapter(cmd);
           cmd.CommandType = CommandType.Text;
           DataSet ds = new DataSet();
           da.Fill(ds);
           foreach (DataRow dr in ds.Tables[0].Rows)
           {
               bk.Add(new Book()
               {
                   Name = dr[0].ToString(),
                   Author = dr[1].ToString()
               });
           }
           cmd.ExecuteNonQuery();
           return View();


       }

[Edit]Code blocks added[/Edit]

Posted 3-Apr-13 21:37pm

arthamsai

Updated 4-Apr-13 0:07am

v4

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Keith Barrow · Accepted Answer · 2013-04-04T00:37:00

There are at least two things wrong here:

First the view is expecting a model of type demo.mvc.Models.Book The name implies that this is an individual book, so it would make sense for it to implement GetEnumerator which is intended for use with collections such as lists etc. The view is probably expecting the wrong type (though it could be the case that Book is a collection, in which case it should inherit from IEnumerable at the very least). You need to check what the type you should be using, I'd expected a View model containing a List<Book> or just the list passed directly (though this is less good practise IMO) given what is said in the rest of your code:

C#

csHtml:
@{
    ViewBag.Title = "Index";
}
@model List<demo.mvc.Models.Book>

Second your controller gets a list of books, but never passes the data in to the view, assuming you are binging to the list:

public ActionResult Index()
       {
           List<Book> bk = new List<Book>();
           //........... snip
           return View(bk);


       }

Given that this looks like a sample, I'd suggest you research Model-View-ViewModel (MVVM) in MVC, it'll save a lot of headache as you start to work on more complex things.