Unable to concatenate a string variable in javascript alert box

Question

0.00/5 (No votes)

See more:

I am trying to concatenate a string variable inside alert box but its not working. When I write text inside this alert box without concatenating this variable it works. Below is my code

C#

string valid = "";
if (FileUpload1.HasFile)
                {
                    string extension = Path.GetExtension(FileUpload1.FileName);
                    if (extension == ".jpg" || extension == ".jpeg" || extension == ".png")
                    {
                        string no = Guid.NewGuid().ToString().Substring(0, 4);
                        string path = @"~/Admin/Logos/";
                        string serverpath = Server.MapPath(path);
                        string name = FileUpload1.FileName;
                        string fullpath = serverpath + no + name;
                        FileUpload1.SaveAs(fullpath);
                        dbpath = path + no + name;
                        
                    }
                    else
                    {
                        valid = "File extension should be jpg,jpeg or png\n";
                    }
                }
                else
                {
                    valid = "Please choose a logo to upload\n";
                }

                if (valid != "")
                {
                    ClientScript.RegisterStartupScript(typeof(Page), "script", "alert('"+valid+"');", true);
                }

Thanks..

Posted 7-Apr-13 22:04pm

lucky050

Add a Solution

Comments

Naz_Firdouse 8-Apr-13 4:16am

please check this...
string customerNo = "28272";
string ErorMessage = "cannot be found";
ClientScript.RegisterStartupScript(typeof(Page), "script", "alertMessage('" + customerNo + "','"+ ErorMessage +"');", true);

The link is
http://forums.asp.net/t/1654753.aspx/1

2 solutions

Solution 1

I have got a similar thing working on one of my own pages. Try losing the single quotes from inside the alert statement and just pass the variable directly:

C#

ClientScript.RegisterStartupScript(typeof(Page), "script", "alert(" + valid + ");", true);

EDIT: on second thought, this only seems to work if 'valid' contains a numeric value, not a string. See Pallavi's solution for the correct answer.

Posted 7-Apr-13 23:01pm

Nick Fisher (Consultant)

Updated 7-Apr-13 23:14pm

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Pallavi Waikar · Accepted Answer · 2013-04-07T23:09:00

Solution 2

it is happening because of \n
use

valid = "File extension should be jpg,jpeg or png";

at the place of

valid = "File extension should be jpg,jpeg or png\n";

Posted 7-Apr-13 23:09pm

Pallavi Waikar