counting the frequency of words in a textfile its not doing what I want it to do don't know why

Question

1.00/5 (2 votes)

See more:

jbtLoad.addActionListener(new ActionListener(){
         public void actionPerformed(ActionEvent e){
             
            
           try {
              Scanner fileScanner = new Scanner(new File("SONGDATA.txt"));
              fileScanner.useDelimiter(",");
                  
                  while (fileScanner.hasNext())
                  {
                    String nextWord=fileScanner.next();
                    nextWord=nextWord.toLowerCase();
                    Object frequency=wordTable.getValue(nextWord);
                    
                  if (frequency==null)
                          {
                              wordTable.add(nextWord,new Integer(1));
                          }
          else
                  {
                      Integer counter=(Integer) frequency;
                     int wordFrequency=counter.intValue();
                      wordFrequency++;
                      
                      wordTable.add(nextWord, new Integer(wordFrequency));
                  }
             }
              
               }catch (FileNotFoundException ex) {
                 JOptionPane.showMessageDialog(null,"Empty File.\n\n" + ex.getMessage());  
               } 
           display();
          }   
         });

Posted 15-Apr-13 9:50am

Sneh_Blose

Updated 15-Apr-13 9:52am

Richard C Bishop

v2

Add a Solution

Comments

Richard C Bishop 15-Apr-13 15:53pm

You will need to ask a question and provide more details for anyone to help you.

Sergey Alexandrovich Kryukov 15-Apr-13 16:26pm

I can see at least one problem; please see my solution.
—SA

Richard C Bishop 15-Apr-13 16:28pm

Nice work.

Sneh_Blose 15-Apr-13 16:04pm

Its basically what I wrote in the subject, I have code to count the frequency of words in a textfile but somehow its not counting it properly. I'm not sure where I messed up in this code

Sergey Alexandrovich Kryukov 15-Apr-13 16:08pm

The problem is: this is incomplete code. Word table is not declared here.
—SA

Sergey Alexandrovich Kryukov 15-Apr-13 16:48pm

I would like to warn you about asking such questions. Please see my answer and the discussion about deletion of incorrect questions, between CPallini and myself. Please don't be confused it you did not understand what we are talking about, I'll explain.

We recently had a discussion about handling non-questions. Formally, your post is formulated as non-question. Please, understand that we are overwhelmed with non-questions. Very routinely, I simply remove such posts if there are no formal signs of being a question. I made an exception for your post, which is not a question but I found it reasonable otherwise.

Other experts will only report the post for abuse, which can be even worse: if some feel that you regularly abuse (no, you personally cannot be blamed for that, but should better be more careful), some will also report on the account. The post can be removed or reported for abuse even by accident. You don't want it, so please carefully shape the post as a question: a question form of some sentence with the question mark at the end, carry the sense of the question, etc. It's easy and will help you to get help.

Thank you for understanding,
—SA

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Answer 1 · 2013-04-15T10:26:00

Please see my comment to the question: some important declarations are missing.

However, I think I can see at least one more or less apparent bug, which is apparent even without knowing the detail of wordTable implementation. The bug is in this line:

Java

wordTable.add(nextWord, new Integer(wordFrequency));

Most likely, this method adds a new object to wordTable. Instead, this object should have a way to retrieve existing object and increment it's integer member. Furthermore, if this is the case and if your code does not throw an exception, the wordTable object does not support uniqueness by the key, where the key should be the word (string).

Correct implementation can be based, for example on java.util.HashMap<String, Frequency>:
http://docs.oracle.com/javase/6/docs/api/java/util/HashMap.html[^],
see also: http://en.wikipedia.org/wiki/Hash_map[^].

In this declaration, the type Frequency is some class with integer frequency member. The class is needed to have a reference-type object for the hash map value, so you could update it when needed.

It allows to search the object by key (String, in your case) with the computational time complexity of O(1).
(Please see http://en.wikipedia.org/wiki/Big_O_notation[^].)

When you got a new word from fileScanner, you should get the Frequency object from the hash map. If the value is no found, add a new object with the frequency of 1. If it is found, increment its value by 1. At the end, you will have the dictionary of words with respective frequencies.

—SA

CPallini · Answer 2 · 2013-04-15T10:30:00

As others already pointed out, your question (and your code) is incomplete. Hence I may give you just a couple of remarks:

Are you sure the world delimiter is just a comma (usually it is a blank and other punctuation characters)?
Quote:
wordTable.add(nextWord, new Integer(wordFrequency));
this line looks suspicious. You shouldn't add, you should instead set that is overwrite previous frequency value with the new one (just a guess, as Sergey pointed out you didn't provide wordTable declaration).

counting the frequency of words in a textfile its not doing what I want it to do don't know why

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0