using onclick opening a new window,only if certain functions execute successfully

Question

0.00/5 (No votes)

See more:

In my html page i inserted a submit button and when the button is clicked 3 javascript functions named xyZ(),abC(),deF() need to be executed.

When all the 3 functions are executed successfully then only i want to show the hello.html page.

But now i am getting the hello.html page even if the functions don't get executed successfully.

HTML

<script>
function open_win()  {
    if(xyZ() && abC() && deF())            
        window.open("hello.html","_blank","width=400");
    else
        alert("Register Again");
}
</script>
<html> 
<input type="submit" onclick="xyZ(),abC(),deF(),open_win()">
</html>

what should i write to correct the problem?

Posted 25-Apr-13 3:42am

sash_kp

Updated 25-Apr-13 5:03am

Prasad Khandekar

v2

Add a Solution

Comments

Prasad Khandekar 25-Apr-13 11:04am

Change the type to button instead of submit. Your HTML is very wrong though. form elements should be placed inside the form element, which inturn will be placed insde body element. Similarly I will suggest to move script inside the head element.

And also change button code as

<input type="button" önclick="open_win()"/>

if you want to call all the function before open_win call even though your are calling them from open_win then change the button code as

<input type="button" önclick="xyz();abc();def();open_win();"/>

sash_kp 25-Apr-13 13:57pm

Actually i have designed a registration form in which first name,last name,user name,password etc are there.I have written validation codes for each of these individually in separate functions.One function for one validation.Like,fname() for first name and so on.

I have also designed an html page which i want to show on successful validations of all the fields.But for that all the functions are needed to be executed first,if all the validations are satisfied,then only the html page saying "registration successful" will be displayed.

Chinmaya C 25-Apr-13 12:09pm

Don't know why you are invoking xyZ(), abC(), deF() twice. one by onClick event and the other time you are invoking in open_win().

And one more thing are you sure you are returning true/false based on the success or unsuccessful execution of these functions?

sash_kp 25-Apr-13 13:56pm

Actually i have designed a registration form in which first name,last name,user name,password etc are there.I have written validation codes for each of these individually in separate functions.One function for one validation.Like,fname() for first name and so on.

I have also designed an html page which i want to show on successful validations of all the fields.But for that all the functions are needed to be executed first,if all the validations are satisfied,then only the html page saying "registration successful" will be displayed.

Chinmaya C 26-Apr-13 0:28am

I think you need to modify the below statement
<input type="submit" önclick="xyZ(),abC(),deF(),open_win()">
to
<input type="button" önclick="return open_win();"/>

and in open_win() :
function open_win() {
if(xyZ() && abC() && deF())
window.open("hello.html","_blank","width=400");
else
alert("Register Again");
}

and modify all other function to:
function xyZ(){
if(...) // your validation goes here
{
return true;
}
else
{
return false;
}
}

similarly modify all other functions as above.

hope this will help. :)

sash_kp 26-Apr-13 4:09am

It somehow worked for me...Thanks a lot for your suggestion...":)"...putting all other functions inside open_win() and returning true or false...Especially These 2 ideas worked for me.

Chinmaya C 26-Apr-13 4:42am

Are you facing any other problem??

sash_kp 28-Apr-13 7:47am

Nope boss..for the time being i am not..I 'll let you know once i have some bug..Thanks..":)"

Chinmaya C 29-Apr-13 3:01am

Welcome. :)

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)