select query incorrect syntax problem

Question

0.00/5 (No votes)

See more:

here is my select query

C#

String selQuery = "SELECT (Bus_Route,Cost) FROM MapDataImage WHERE Source='" + Source_Box.Text + "' AND Destination='" + Distance_Box.Text + "'";
            {
                scmd1 = new SqlCommand(selQuery, conn2);
                SqlDataReader sqldread2 = scmd1.ExecuteReader();
                RouteDetails.Text = sqldread2["Bus_Route" + " Cost "].ToString();

            }

Executequery gives me error call

Incorrect syntax near ','.

basically i want to add two column data into one textbox

so is this method wrong?

Thanks

Posted 26-Jul-13 20:54pm

promod madushan

Add a Solution

2 solutions

Solution 1

Remove the brackets to start with:

C#

String selQuery = "SELECT Bus_Route,Cost FROM MapDataImage WHERE Source='" + Source_Box.Text + "' AND Destination='" + Distance_Box.Text + "'";

Then stop doing SQL like that! Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead:

C#

String selQuery = "SELECT Bus_Route,Cost FROM MapDataImage WHERE Source=@SC AND Destination=@DS";
scmd1 = new SqlCommand(selQuery, conn2);
scmd1.Parameters.AddWithValue("@SC", Source_Box.Text);
scmd1.Parameters.AddWithValue("@DS", Distance_Box.Text);
SqlDataReader sqldread2 = scmd1.ExecuteReader();
if (sqldread2.Read())
   {
   RouteDetails.Text = sqldread2["Bus_Route" + " Cost "].ToString();
   }

Posted 26-Jul-13 21:00pm

OriginalGriff

Comments

promod madushan 27-Jul-13 3:33am

it still gives me error in final code...

RouteDetails.Text = sqldread2["Bus_Route" + " Cost "].ToString();

error...
says
Bus_Route Cost

promod madushan 27-Jul-13 3:38am

if i do like this
RouteDetails.Text = sqldread2["Bus_Route"].ToString();
it will give an answer...
but i want to get two column details into one textbox

OriginalGriff 27-Jul-13 3:55am

Then you need to either change the query, or merge them in the C# code.
C# is probably easier:
RouteDetails.Text = string.Format("{0} {1}", sqldread2["Bus_Route"], sqldread2[Cost"]);

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

promod madushan · Accepted Answer · 2013-07-26T21:48:00

C#

String selQuery = "SELECT Bus_Route,Cost FROM MapDataImage WHERE Source=@SC AND Destination=@DS";
            
                scmd1 = new SqlCommand(selQuery, conn2);
                scmd1.Parameters.AddWithValue("@SC", Source_Box.Text);
                scmd1.Parameters.AddWithValue("@DS", Distance_Box.Text);
                SqlDataReader sqldread2 = scmd1.ExecuteReader();
                if (sqldread2.Read())
                {
                    string newline = "Bus Route  = " + sqldread2["Bus_Route"].ToString() + "\r\n" + "Cost  = " + sqldread2["Cost"].ToString();
                    RouteDetails.Text = newline;
                    
                }

Done