String inside of MenuStrip.text is getting extra line at the end

Question

0.00/5 (No votes)

See more:

I am having an issue where I trim a string down, and attempt to put that information inside of a menustrip's text, it ends up adding a line to the end of it. I have tested this with the library being the only line of text from the text file its reading from, and with other information the program saves after that, no luck.
Thanks for reading

So where I'm attempting to get this:

VB

Set to: [H:\Guitar]

shows up in menu strip sub menu as 2 lines :

VB

Set to: [H:\Guitar
]

Code during form load:

VB

Dim FileToCheck = (Application.StartupPath & "\settings.gtr")
If File.Exists(FileToCheck) = True Then
    TempBox.Text = (My.Computer.FileSystem.ReadAllText(FileToCheck))
    TempBox.Text = Replace(TempBox.Text, vbLf & vbCr, "")

    If (TempBox.Text.Contains("library=")) Then
        Dim startLocation As Int32 = InStr(TempBox.Text, "library=") + 7
        Dim ValueToReplace = (TempBox.Text.Substring(startLocation, InStr(startLocation, TempBox.Text, Chr(13)) - startLocation))
        ToolStripMenuItem2.Visible = True
        ToolStripMenuItem2.Text = ("Set to: [" & ValueToReplace & "]")
    End If
End If

Code to save library path:

VB

Public Sub WriteLibraryPath(ByVal path As String)
    TempBox.Text = ""
    Dim Settings = (Application.StartupPath & "\settings.gtr")
    If File.Exists(Settings) = True Then
        TempBox.Text = My.Computer.FileSystem.ReadAllText(Settings)
        TempBox.Text = Replace(TempBox.Text, vbLf & vbCr, "")
        If (TempBox.Text.Contains("library=")) Then
            Dim startLocation As Int32 = InStr(TempBox.Text, "library=") + 7
            Dim ValueToReplace = TempBox.Text.Substring(startLocation, InStr(startLocation, TempBox.Text, Chr(13)) - startLocation)
            TempBox.Text = TempBox.Text.Replace(ValueToReplace, path + vbNewLine)

        Else
            TempBox.Text = TempBox.Text & "library=" & path & vbNewLine
        End If
        File.WriteAllText(Settings, TempBox.Text)
    End If

    If File.Exists(Settings) = False Then
        Dim objwriter As New StreamWriter(Settings)
        objwriter.WriteLine("library=" & path)
        objwriter.Close()
        objwriter.Dispose()
    End If
End Sub

Posted 27-Jul-13 20:24pm

Member 10176068

Updated 27-Jul-13 20:33pm

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2013-07-27T20:36:00

The problem is Chr(13). This is one of the end-of-line separators. Please see: http://en.wikipedia.org/wiki/Newline[^].

None of end-of-line characters should appear in most controls and other UI elements, such as a menu item. Run your code under the debugger and make sure you never insert such thing. And even in other cases, when you really need to insert such thing, you should not use Chr(13) or anything else as an immediate constant. As you can see from the article referenced above, it depends on OS, so you need to use the static property System.Environment.NewLine instead:
http://msdn.microsoft.com/en-us/library/system.environment.newline.aspx[^].

One more, minor problem in your code: using string concatenation. Strings are immutable, so using string concatenation repeatedly is bad (do I have to explain why). Instead, prefer using string.Format. If it is not suitable (for example, in loops), use the mutable class System.Text.StringBuilder:
http://msdn.microsoft.com/en-us/library/system.text.stringbuilder.aspx[^].

—SA