How to fix .... 0xC0000005: Access violation reading location 0xccdfc15c.

Question

1.00/5 (1 vote)

See more:

I am Getting First-chance exception error in Visual Studio 2005, after running the application... Anyone help me to fix this ....Thanks

[Copied code from below comment]

void CEditBox_1Dlg::OnBnClickedButton1()
{ 
    // TODO: Add your control notification handler code here 
    CString csSamplFreq; 

    char carrSamplFreq[50],csTemp[50]; 
    char *pcSamplFreq = NULL; 
    pcSamplFreq =(char*)carrSamplFreq; 

    m_CntrlDisplay.SetFocus(); 
    m_CntrlDisplay.GetWindowText(csSamplFreq); 
    strcpy(carrSamplFreq,(LPCSTR) (CStringA)csSamplFreq); 
    pcSamplFreq += usCurPos; 
    sprintf(csTemp,"%s",pcSamplFreq); 
    for(short sLoop = 0;sLoop<strlen((char*)csTemp);sLoop++) 
    { 
        *pcSamplFreq =csTemp[sLoop]; pcSamplFreq++; 
    } 
    *pcSamplFreq = '\0'; 
    csSamplFreq.Format(L"%s",carrSamplFreq); 
    m_CntrlDisplay.SetWindowText(csSamplFreq); 
    usCurPos++; 
    m_CntrlDisplay.SetSel(usCurPos,usCurPos); 
    //m_CntrlDisplay=atoi(carrSamplFreq); 
    m_TxtSamplingFrequency = carrSamplFreq; 
    UpdateData(false);
}

Posted 17-Dec-13 19:13pm

Baakki

Updated 17-Dec-13 21:14pm

Jochen Arndt

v2

Add a Solution

Comments

CPallini 18-Dec-13 1:15am

Without seeing the code how could we help you?

Baakki 18-Dec-13 2:03am

This is my code...I am getting error , when the control goes to sprintf .....

<pre lang="cs">void CEditBox_1Dlg::OnBnClickedButton1()
{
// TODO: Add your control notification handler code here

CString csSamplFreq;

char carrSamplFreq[50],csTemp[50];
char *pcSamplFreq = NULL;
pcSamplFreq =(char*)carrSamplFreq;

m_CntrlDisplay.SetFocus();

m_CntrlDisplay.GetWindowText(csSamplFreq);

strcpy(carrSamplFreq,(LPCSTR) (CStringA)csSamplFreq);

pcSamplFreq += usCurPos;

sprintf(csTemp,"%s",pcSamplFreq);

for(short sLoop = 0;sLoop<strlen((char*)csTemp);sLoop++)

{

*pcSamplFreq =csTemp[sLoop]; pcSamplFreq++;

}

*pcSamplFreq = '\0';

csSamplFreq.Format(L"%s",carrSamplFreq);
m_CntrlDisplay.SetWindowText(csSamplFreq); usCurPos++;
m_CntrlDisplay.SetSel(usCurPos,usCurPos);

//m_CntrlDisplay=atoi(carrSamplFreq);
m_TxtSamplingFrequency = carrSamplFreq;

UpdateData(false);</pre>

Jochen Arndt 18-Dec-13 3:19am

I have copied the code from your comment to the question.

What do you want to achieve? You are copying string contents without any sense. Try to simplfy the code.

There are two points that may result in access violations:
- When the text in the control is longer than 49 chars, you have an buffer overrun on carrSamplFreq
- When usCurPos is greater than the length of the carrSamplFreq string, pcSamplFreq points to a not initialised string (which may be also beyond the valid locations)

3 solutions

Solution 2

Quote:
strcpy(carrSamplFreq,(LPCSTR) (CStringA)csSamplFreq);

This is not the correct way for assigning a (wide) CString content to character array.

Quote:
pcSamplFreq += usCurPos;
sprintf(csTemp,"%s",pcSamplFreq);

I suppose usCurPos is out-of-control there.

I think in your case it would probably better if you tell us what are trying to achieve instead of insist on fixing the ugly CString-character array mixture.

Posted 17-Dec-13 21:40pm

CPallini

Comments

Baakki 18-Dec-13 4:29am

I want to develop a edit box application, when I press a button, a character(A or B like wise) should get updated on the edit box and the cursor should update ie.., move to next position...

CPallini 18-Dec-13 4:34am

Do you mean: "I want to append characters to the edit box on button click" ?
You know, you may manipulate the text using the '+' operator of the CString object.

Baakki 18-Dec-13 5:12am

Yes I want to append a character to the edit box on button click.....Do u hav any idea ?

CPallini 18-Dec-13 5:30am

Yes:


CString text;
MyEdit.GetWindowText(text);
MyEdit.SetWindowText(text + L'A');

Baakki 18-Dec-13 6:02am

Yeah that's correct..., but in order to update the cursor, setfocus and setsel needed right ?

Maciej Los 18-Dec-13 6:47am

Hawk eye ;)
+5!

Solution 3

Bin sprintf and get rid of any arrays and pointers. Learn how to use std::stringstream and std::string. If you've still got a problem then come back and ask again.

Posted 17-Dec-13 21:54pm

Aescleal

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Maciej Los · Accepted Answer · 2013-12-17T19:56:00

Solution 1

There is not enough information to answer this question with details. The most often reason is: you're trying to read unallocated memory.

I would suggest you to read this: Analyze Crashes to Find Security Vulnerabilities in Your Apps[^].
Please, debug you program and check for errors.

Posted 17-Dec-13 19:56pm

Maciej Los

Comments

Baakki 18-Dec-13 6:45am

I want to append a character to the edit box on button click.....Do u hav any idea ?

Maciej Los 18-Dec-13 6:47am

Please, read CPallini's comments.