Inserting into database problem

Question

1.00/5 (3 votes)

See more:

I have an textbox in which i am writing product Names separated by a comma(,). I want to insert that product Names into database. But if the product Name already exist then update it otherwise
if a new product name in the textbox then i have to insert into database. how will i do it Please help . This is my code.

C#

String Serials = TextBox7.Text;
    //    String[] SerialArray = Serials.Split(',');
    //    for (int i = 0; i < SerialArray.Length - 1; i++)
    //    {
    //        con.Open();
    //        string ratecard = "Insert into Ratecard (Vendor_Name,Asset_type,New,Refurbish,Repaired) values('" + TextBox1.Text + "','" + SerialArray[i] + "',0,0,0)";
    //        SqlCommand cmdd = new SqlCommand(ratecard, con);
    //        cmdd.ExecuteNonQuery();
    //        con.Close();

Posted 1-May-14 1:22am

Member 10578683

Updated 1-May-14 1:41am

Thanks7872

v2

Add a Solution

Comments

[no name] 1-May-14 7:30am

Your code is commented out.
You are not checking the database for your existing name.
You are using string concatenation to construct your query.
You are opening and closing your connection every time through your for loop.
Why would you need to update the name if it exists?

Member 10578683 1-May-14 7:55am

nothing to update i just want to insert those Asset_type that is not in the db

[no name] 1-May-14 8:28am

Okay then why did you say you needed to update the name? Did you bother going and fixing any other problems pointed out to you yet?

Sanket Saxena 1-May-14 7:34am

Is this the code you are using to save the value in the DB. (its commented)?

Member 10578683 1-May-14 7:54am

No no it is wrongly commented

Peter Leow 1-May-14 8:56am

How do you expect us to provide a correct solution to a wrong question? This is not a question.

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thanks7872 · Answer 1 · 2014-05-01T01:41:00

Solution 1

You can make use of sp as follows:

C#

CREATE PROCEDURE [Insert_Update_Details]
(
   //parameters
)
AS
BEGIN
if exists (your query to check the existence of specified value) 
//update query 
else 
//insert query 
END

Posted 1-May-14 1:41am

Thanks7872

DamithSL · Answer 2 · 2014-05-01T02:02:00

you can change the sql statement bit,

C#

SqlCommand cmdd = new SqlCommand("IF NOT EXISTS(SELECT 1 from Ratecard where Vendor_Name='" + TextBox1.Text + "')" +
                " Insert INTO Ratecard (Vendor_Name,Asset_type,New,Refurbish,Repaired) VALUES('" + TextBox1.Text + "','" + SerialArray[i] + "',0,0,0)"+
                " else" +
                " UPDATE Ratecard SET Asset_type ='" + SerialArray[i] + "' WHERE  Vendor_Name= '" + TextBox1.Text + "'", con);

Don't concatenate sql statement like above, it is not the best practice
your program is widely open for sql injection attacks, try to use parameterized sql