using database data to mark some checklistbox items as checked in windows form

Question

0.00/5 (No votes)

See more:

Am using the following codes to save data which have been checked in a checkedlistbox
into sql db. Now i want select the saved data and checked them in the checklistbox. Please help
me out

public void saveMinistry()
        {
            SqlConnection conn = new SqlConnection(ConfigurationSettings.AppSettings["ConnectionString"]);
            conn.ConnectionString = "Data Source=USER-PC;Initial Catalog=PIWCDB;User ID=sa;Password=mike";

            string StrQuery;

            foreach (var checkedItem in this.cblMinistries.CheckedItems)
            {
                SqlCommand comm = new SqlCommand();
                comm.Connection = conn;

                StrQuery = @"INSERT INTO tblMembershipministry VALUES ('" + this.txtMembershipid2.Text + "', '" + checkedItem + "')";

                comm.CommandText = StrQuery;
                conn.Open();
                comm.ExecuteNonQuery();
                conn.Close();
            }
            //MessageBox.Show("Record was successfully Added");
        }

am trying to use this code but not working. help me out

public void searchMinistry10()
        {
            SqlConnection conn = new SqlConnection(ConfigurationSettings.AppSettings["ConnectionString"]);
            conn.ConnectionString = "Data Source=USER-PC;Initial Catalog=PIWCDB;User ID=sa;Password=mike";

            string StrQuery;

            foreach (var checkedItem in this.cblMinistries.CheckedItems)
            {
                SqlCommand comm = new SqlCommand();
                comm.Connection = conn;

                StrQuery = @"SELECT * FROM tblMembershipministry WHERE FormattedMembershipid = '" + this.txtMembershipid2.Text + "'";

                comm.CommandText = StrQuery;
                conn.Open();
                comm.ExecuteNonQuery();
                conn.Close();
            }
            //MessageBox.Show("Record was successfully Added");
        }

Posted 7-May-14 6:47am

mikeoabban

Updated 7-May-14 13:11pm

v2

Add a Solution

Comments

Maciej Los 7-May-14 13:08pm

Not enough information. Please, post sample data. Use "Improve question" widget.

[no name] 7-May-14 20:20pm

It's "not working" because you are not doing anything with the result of your query. You need to ExecuteReader not ExecuteNonQuery. And you are opening yourself up to SQL injection attacks. And why on earth are you executing your query for every checked item? You are just guessing at what you are doing.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ZurdoDev · Accepted Answer · 2014-05-07T07:24:00

Solution 1

You need to write a SELECT statement to pull the data from the database. Then you loop through your data, probably using a DataReader, and set the appropriate checkboxes.

Posted 7-May-14 7:24am

ZurdoDev

Comments

mikeoabban 7-May-14 19:13pm

my problem is how to loop through and check them in the checklistbox.
please have a look at the improved question

ZurdoDev 7-May-14 20:02pm

You need to think out it first.

1. Run your sql
2. Loop through the records
3. Find the matching checkbox list item and check it.

mikeoabban 7-May-14 20:20pm

thanks for the help. am using this codes but not working. what might be problem

public void Newsearch()
{
SqlConnection conn = new SqlConnection(ConfigurationSettings.AppSettings["ConnectionString"]);
conn.ConnectionString = "Data Source=USER-PC;Initial Catalog=PIWCDB;User ID=sa;Password=mike";

conn.Open();
SqlCommand cmd = new SqlCommand();
string sqlQuery = "SELECT Ministryname FROM tblMembershipministry WHERE FormattedMembershipid = '" + this.txtMembershipid.Text + "'";
// System.Data.SqlClient.SqlCommand cmd = new System.Data.SqlClient.SqlCommand();
cmd.Connection = conn;
cmd.CommandText = sqlQuery;
cmd.CommandType = System.Data.CommandType.Text;

System.Data.SqlClient.SqlDataReader dr = null;
dr = cmd.ExecuteReader();

if (dr.Read())
{

foreach (int i in cblMinistries.CheckedIndices)
{
cblMinistries.SetItemCheckState(i, CheckState.Checked);
}
}

}