javascript function not calling on clicking button for the first time.

Question

1.00/5 (1 vote)

See more:

I have a grid which has a select button to select row data.On select button click i want to open another page in another tab.
javascript function:=

C#

function opentab() {
            var vrn = document.getElementById("<%=hdnvrno.ClientID%>").value;
            window.open("ABC.aspx?vrno=" + vrn + "", "_blank");
        }

ASPX:=

XML

<asp:UpdatePanel ID="UpdatePanel1" runat="server">
      <ContentTemplate>

<asp:HiddenField ID="hdnvrno" runat="server" Value="" />
<asp:GridView ID="GridView1" runat="server">
<columns>

XML

<asp:TemplateField>
                                           <ItemTemplate>
                                               <asp:Button ID="btnSelect" runat="server" Text="s" Width="7px" CommandName="Select" CommandArgument='<%# Eval("VAL") %>' />
                                           </ItemTemplate>
                                       </asp:TemplateField>

CODE BEHIND :=

C#

protected void GridView1_RowCommand(object sender, GridViewCommandEventArgs e)
      {
          if (e.CommandName == "Select")
          {
             string  VAL= e.CommandArgument.ToString();

Button btnlink = (Button)e.CommandSource;
hdnvrno.Value = VAL;
btnlink.Attributes.Add("OnClick", "opentab();");
}
}
when i firstly click on select button the function js function is not called when i click it secondly it gets called.Whats the problem i m not able to understand.
Help me plzzz.

Posted 27-May-14 20:02pm

pwavell

Updated 25-May-20 20:38pm

v3

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Bh@gyesh · Answer 1 · 2014-05-27T21:13:00

Solution 1

Hi,

When the code "btnlink.Attributes.Add("OnClick", "opentab();");" execute first time, it will register clickevent(javascript) with button click so it is not called first time. Then next time if you click button again, the registered event will be called so second time you get call for that function.

To overcome this problem, you need to register this event (i.e. btnlink.Attributes.Add("OnClick", "opentab();")) in gridview_load event. So when grid is loaded first time, the event will be registered for button click.

Ask me if you have any doubt.

Thanks,
Bh@gyesh

Posted 27-May-14 21:13pm

Bh@gyesh

Comments

pwavell 28-May-14 5:15am

where and how to register this event?

Bh@gyesh 28-May-14 8:07am

Add RowDataBound event in grid and register buttonclick event in that.

Eg.

protected void GridView1_RowDataBound(object sender, GridViewRowEventArgs e)
{
if (e.Row.RowType == DataControlRowType.DataRow)
{
Button btn = (Button)e.Row.FindControl("btnSelect");
btn.Attributes.Add("OnClick", "opentab();");
}
}

and remove "btnlink.Attributes.Add("OnClick", "opentab();");" line from RowCommand event.

Bh@gyesh 31-May-14 1:02am

Is it working or not?

pwavell 31-May-14 2:43am

nope... still not working...

Bh@gyesh 2-Jun-14 0:12am

I created an application like your code and it is working..