The connection was not closed, The connection's current state is open

Question

5.00/5 (1 vote)

See more:

C#

try
        {
            if (HttpContext.Current.Request.Cookies["CRegistrationID"].Value != "")
            {
            if (FUImages.HasFile && FUBrochure.HasFile)
            {


                string CateName = ddlCreateAddCategory.SelectedItem.ToString();
                string ArName = ddlCreateAddArea.SelectedItem.ToString();

                Con.Open();

                string uid = HttpContext.Current.Request.Cookies["CRegistrationID"].Value;

                HttpContext.Current.Response.Cookies["Image"].Value = CateName;
                HttpContext.Current.Response.Cookies["Upload"].Value = ArName;

                ImageAutoNum = Guid.NewGuid().ToString();
                ImageAutoNum = ImageAutoNum.Substring(0, 3);

                FUImages.SaveAs(Server.MapPath("~/ConsumerImages/" + ImageAutoNum + FUImages.FileName));
                ImageUrl = "~/ConsumerImages/" + ImageAutoNum + FUImages.FileName;

                ImageAutoNum2 = Guid.NewGuid().ToString();
                ImageAutoNum2 = ImageAutoNum2.Substring(0, 3);

                FUBrochure.SaveAs(Server.MapPath("~/ConsumerImages/" + ImageAutoNum2 + FUBrochure.FileName));
                FUBImages = "~/ConsumerImages/" + ImageAutoNum2 + FUBrochure.FileName;

                Cmd = new SqlCommand("Insert into ConsumerAdvertiesment(CategoryName,ADshop_name,ADShop_Address,ADshop_city,ADShop_mob,ADshop_Email,RegistrationId,startddate,endddate,ImageName,Description,ImagePath,BImageName,BImagePath,Status) values('" + CateName + "','" + txtshopname.Text + "','" + txtCadress.Text + "','" + txtCity.Text + "','" + txtcontact.Text + "','" + txtemail.Text + "','" + uid + "','" + txtstart.Text + "','" + txtEnd.Text + "','" + ImageUrl + "','" + txtDesc.Text + "','" + ImageUrl + "','" + FUBImages + "','" + FUBImages + "','Active')", Con);
                Cmd.ExecuteNonQuery();

                Response.Redirect("Success.aspx?Pop=Adv");
                Con.Close();

            }
            else
            {
                ScriptManager.RegisterStartupScript(this, GetType(), "showalert", "alert('Please Select Image & Brochure');", true);
            }
            }
            else
            {
                Response.Cookies["LoginRedirect"].Value = "Yes";
                ScriptManager.RegisterStartupScript(this, GetType(), "showalert", "alert('Please Log in First !!! ');", true);
            }
        }
        catch (Exception ex)
        { }
        finally
        {
            Con.Close();
        }

Posted 4-Jul-14 20:40pm

Dixit Ashish

Add a Solution

Comments

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 5-Jul-14 3:11am

On which line?

3 solutions

Solution 1

Hi,
if you get that problem you should close the existing open connection, before opening connection

before the line
con.Open();

place the code
if(con.ConnectionState == ConnectionState.Open)
{
Con.close();
}

it should solve your problem,

Posted 4-Jul-14 20:52pm

sameer549

Comments

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 5-Jul-14 3:29am

Logic is correct, but code is not... See my answer. :)

Solution 3

Don't Share the Connection Object. you can keep connection string on app config or web config.
When you need to do a database operation, create new connection and dispose it after you done with it. following code sample will help you.

C#

using (SqlConnection conn = new SqlConnection(YourConnectionString))
using (SqlCommand cmd = new SqlCommand(SqlString, conn))
{
    conn.Open();
    cmd.ExecuteNonQuery();
}

Posted 4-Jul-14 22:39pm

DamithSL

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) · Accepted Answer · 2014-07-04T21:26:00

Solution 2

C#

if (con.State == ConnectionState.Open)
{
    Con.Close();
}

Posted 4-Jul-14 21:26pm

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ)

Comments

sameer549 5-Jul-14 4:37am

yes you are rite. actually mine is a typing mistake :)

Tadit Dash (ତଡିତ୍ କୁମାର ଦାଶ) 7-Jul-14 6:12am

Cool. :)