Setter Method Checking Problem

Question

1.00/5 (1 vote)

See more:

Hello Everyone!

I Am Trying to understand the Property Method in C#. But During Setting the Value it Did not check the Condition and give me Wrong Answer .Please See the Code me Tell me Good Solution if Possible.

Code

C#

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace PracticeQuestion
{
    class ElementContainer
    {
        private double Length;
        private double Width;

        //Setter and Getter Property

        public double SetLength
        {
            get { return Length;}
            set
            {
                if (Length > 10)
                {
                    Console.Write("\n\nThere is some Bad Input.");
                }
                else
                {
                    Length = value;
                }
            }
        }
        public double SetWidth
        {
            get
            {
                 return Width;
            }
            set
            {
                if (Width > 10)
                {
                    Console.Write("\n\nThere is some Bad Input.");
                }
                else
                {
                    Width = value;
                }
            }
        }
        public ElementContainer ()
        {
            Console.Write("Please Enter The Following Data.");
        }
        public override string ToString ()
        {
            return string.Format("\n\nlength:{0}\n\nWidth:{1}\n\nTotal Area:{2}", Length, Width,Length*Width);
        }
    }
}

C#

class Program
   {
       static void Main ( string[] args )
       {
           ElementContainer Element = new ElementContainer();

//Error Is There

when i set The Value Then i want first it check the Setter Condition then set value According to required Condition.

           Element.SetLength = 10;
           Element.SetWidth = 20;
           Console.Write(Element);
           Console.ReadLine();
       }
   }

Posted 4-Oct-14 20:14pm

Member 11004573

Add a Solution

Comments

Sergey Alexandrovich Kryukov 5-Oct-14 2:28am

Not clear. This code does not seem to be anything practically reasonable, but the problems is not clear.
You limit the size by some previously set size: when it's more then 10, property assignment is ignored, so there is no a possibility to reduce it back. "Wrong Answer" is not defined. "Wrong" depends on your goal, which you did not bother to share with us.
—SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

**Zoltán Zörgő** · Accepted Answer · 2014-10-04T20:25:00

If setter encounters invalid argument, your option is not to write to the console, since that won't provide any information to the caller. You should throw an exception in that case.
Something like this:

C#

public double SetWidth
        {
            get
            {
                 return Width;
            }
            set
            {
                if (value > 10)
                {
                    throw new ArgumentOutOfRangeException("There is some Bad Input.");
                }
                else
                {
                    Width = value;
                }
            }
        }

On the caller side you need try-catch blocks to intercept this.
An other note based on SA's catch: in the setter you need to validate the new value, not the stored one.