How to restrict the incomplete data from storing in sql server db ,If the page uses validation

Question

0.00/5 (No votes)

See more:

I have created an Registration page and the data inserted in the page will be stored in the sql server db.But if I use validation and any particular field is not entered than also it stores the remaining data in db how to restrict that????

C#

protected void Button2_Click(object sender, EventArgs e)
{
    // string query;
    string str = "Data Source=HIMANSHU-PC;Initial Catalog=new1;Integrated  Security=True";
    SqlConnection con = new SqlConnection(str);
    con.Open();
    string query = "insert into logindata values('" + txtname.Text + "','" +    txtlname.Text + "','" + txtuname.Text + "','" + txtpass.Text + "','" + txtcity.Text + "','" + dropdwcou.Text + "')";
    SqlCommand cmd = new SqlCommand(query,con);
    cmd.ExecuteNonQuery();
    con.Close();
}

Posted 15-Oct-14 0:37am

Member 11132163

Updated 15-Oct-14 2:25am

Suraj Sahoo | Coding Passion

v2

Add a Solution

Comments

M.Farrukh Abbas 15-Oct-14 7:24am

used required field validator and for specific business logic validation use custom validation what is the current issue.

NaibedyaKar 15-Oct-14 7:29am

What kind of validations you have used? You can also validate the textbox values on serverside code if you want to double sure on the validations.

Member 11132163 15-Oct-14 7:37am

I have used client side validations

Richard Deeming 15-Oct-14 8:42am

Your code is susceptible to SQL Injection[^].

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

NaibedyaKar · Answer 1 · 2014-10-15T02:02:00

If you are using the client side validatiosn, then things should work fine unless some smart guy is trying to disable javascript and send blank data.
Better to use the requiredfieldvalidator.
http://www.devmanuals.com/tutorials/ms/aspdotnet/requiredfieldvalidator.html[^]
If you want to be more safe then check the textbox null or empty in server side code.

C#

if (!string.IsNullOrEmpty(textbox.text))
{
  //do this
}

I will also like to suggest you to use parameterize query. This will help you from SQL injection. Check^