fetch data in combobox in windows form

Question

4.00/5 (1 vote)

See more:

need to fetch int passno from table in combobox.

below code give error conversion failed

private void vfind_SelectedIndexChanged(object sender, EventArgs e)
        {
            Vbtnsave.Visible = false;
         
                SqlDataAdapter da = new SqlDataAdapter("select * from VisitorPass where PassNo ='" + vfind.SelectedValue.ToString() + "'", objConn1);
                DataSet ds = new DataSet();
                da.Fill(ds, "VisitorPass");
                if (ds.Tables["VisitorPass"].Rows.Count > 0)
                {
                    MainCombo.SelectedValue = ds.Tables["VisitorPass"].Rows[0]["PassType"].ToString();
                    txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["PassNo"].ToString();
                    VdateTimePicker1.Value = Convert.ToDateTime(ds.Tables["VisitorPass"].Rows[0]["Date"].ToString());
                    Dttimein.Value = Convert.ToDateTime(ds.Tables["VisitorPass"].Rows[0]["Timein"].ToString());
                    Dttimeout.Value = Convert.ToDateTime(ds.Tables["VisitorPass"].Rows[0]["Timeout"].ToString());
                    txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["VisitorsName"].ToString();
                    txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["Purpose"].ToString();
                    txtvpassno.Text = ds.Tables["VisitorPass"].Rows[0]["ToSee"].ToString();
                    vauthcombo.SelectedValue = ds.Tables["VisitorPass"].Rows[0]["AuthorisedSign"].ToString();

                
            }
        }

Posted 23-Jan-15 0:21am

Master Vinu

Add a Solution

Comments

Richard Deeming 23-Jan-15 6:45am

Your code is vulnerable to SQL Injection[^].

NEVER use string concatenation to build a SQL query. ALWAYS use a parameterized query.

Master Vinu 23-Jan-15 6:46am

could y pls correct the query then ..yhx in advance

Richard Deeming 23-Jan-15 7:10am

SqlDataAdapter da = new SqlDataAdapter("select * from VisitorPass where PassNo = @PassNo", objConn1);
da.SelectCommand.Parameters.AddWithValue("@PassNo", vfind.SelectedValue);

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)