Problem in Updating the database

Question

0.00/5 (No votes)

See more:

In my project Users can edit their profile information which is already displayed in text boxes from the database and they can save changes.But the problem is though I edit the data in the textbox, while updating it takes only the older value in that textbox and I can't understand the reason. Can anyone know how to solve this?

VB

Protected Sub Page_Load(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Load
        Dim con As New SqlConnection("Data Source=CSC32\SQLEXPRESS;Initial Catalog=Data1;Integrated Security=True;")
        Dim cmd As SqlCommand
        Dim name As String = Session("User")
        con.Open()
        cmd = New SqlCommand("SELECT * from Logs", con)
        Dim reader As Data.SqlClient.SqlDataReader = cmd.ExecuteReader()
        Dim f As Integer = 0
        If (reader.HasRows()) Then
            While (reader.Read())
                If (name.CompareTo(reader("Username")) = 0) Then
                    f = 1
                    GoTo l1
                Else
                    f = 0
                End If
            End While
l1:         If f = 1 Then
                eidtext.Text = reader("Email")
                dob.Text = reader("DOB")
                sqtext.SelectedItem.Text = reader("Secques")
                satext.Text = reader("Secans")
            End If
        End If
        con.Close()
    End Sub




Protected Sub Savechanges_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles Savechanges.Click
        Dim con As New SqlConnection("Data Source=CSC32\SQLEXPRESS;Initial Catalog=Data1;Integrated Security=True;")
        con.Open()
        Dim adp As New SqlDataAdapter
        Dim cmd As New SqlCommand("update Logs set Email='" + eidtext.Text + "', DOB='" + dob.Text + "', Secques='" + sqtext.Text + "',Secans='" + satext.Text + "' where Username='" + Session("User") + "';", con)
        adp.UpdateCommand = cmd
        adp.UpdateCommand.ExecuteNonQuery()
        con.Close()
    End Sub

Posted 16-Feb-15 2:40am

Member 11266021

Updated 16-Feb-15 3:02am

v2

Add a Solution

Comments

ZurdoDev 16-Feb-15 8:43am

No one can help see what you did wrong unless you post the relevant code. Click on Improve question and post the relevant code.

2 solutions

Solution 1

I can guess it untill you provide some code.
Check if you have assigned value in some variable while inserting data and the same variable is not assigned with updated value in case if editing data.

Posted 16-Feb-15 2:47am

Paritosh Soni

Updated 16-Feb-15 2:48am

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Wendelius · Accepted Answer · 2015-02-16T03:07:00

First of all, do not ever concatenate values directly to the SQL statement. This leaves you wide open to SQL injections. Instead use SqlParameter[^].

Then you don't need the adapter. Simply:

VB

Dim con As New SqlConnection("Data Source=CSC32\SQLEXPRESS;Initial Catalog=Data1;Integrated Security=True;")
con.Open()
Dim cmd As New SqlCommand("update Logs set Email=@email, DOB=@dob, Secques=@Secques,Secans=@Secans where Username=@username", con)
' SET PARAMETER VALUES OVER HERE
...
cmd.Parameters.AddWithValue("@Secques", sqtext.Text)
...

cmd.ExecuteNonQuery()
con.Close()

Also
- using debugger check that you really use the latest values when assigning the text into parameters.
- it's advisable to use using[^] statement for the connection
- and better yet wrap the DML operations inside a SqlTransaction[^]