How to bind List to gridview

Question

0.00/5 (No votes)

See more:

Hello everyone,

i am trying to display record on gridview by binding List to it, it the last record is overwriting other records! this is my code:

C#

public class BVNNotEnrolledAllBranches
    {
        public string CustomerName { get; set; }
        public string AccountNumber { get; set; }
        public string CIF { get; set; }
        public string PhoneNumber { get; set; }
        public string BranchName { get; set; }
        public string BVN { get; set; }
        public string Email { get; set; }
    }

C#

using (OracleConnection connection = new OracleConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString))
               {
                   DataTable dt = new DataTable();
                   OracleCommand command = new OracleCommand(select, connection);
                   command.CommandTimeout = 900000000;
                   DataSet dataset = new DataSet();
                   OracleDataAdapter adapter = new OracleDataAdapter(command);
                   adapter.Fill(dataset);
                   dt = dataset.Tables[0];
                   List<BVNNotEnrolledAllBranches> gridRecords = new List<BVNNotEnrolledAllBranches>();
                   BVNNotEnrolledAllBranches bvnFeilds = new BVNNotEnrolledAllBranches();
                   lblNoRecord.Text = "Total record(s): " + dt.Rows.Count.ToString();
                   lblNoRecord.ForeColor = System.Drawing.Color.Green;
                   foreach (System.Data.DataRow dr in dt.Rows)
                   {
                       //TransactionModel txn = new TransactionModel();
                       bvnFeilds.CustomerName = (dr["Customer_name"].ToString());
                       bvnFeilds.AccountNumber = (dr["Account_number"].ToString());
                       bvnFeilds.CIF = (dr["CIF_ID"].ToString());
                       bvnFeilds.PhoneNumber = (dr["Phone_Number"].ToString());
                       bvnFeilds.BranchName = (dr["BRANCH_NAME"].ToString());
                       bvnFeilds.BVN = (dr["BVN"].ToString());
                       bvnFeilds.Email = (dr["Email"].ToString());
                       //bvnFeilds.Status = (dr["Status"].ToString());

                       gridRecords.Add(bvnFeilds);
                   }

                   GridView1.DataSource = gridRecords;
                   GridView1.DataBind();
               }

Please is there something i missed out? Thanks in advance.

Posted 17-Apr-15 0:34am

Uwakpeter

Add a Solution

Comments

Member 10427298 17-Apr-15 7:11am

Would show me the GridView1 definition on your .aspx page?

Member 10427298 17-Apr-15 7:14am

In the mean time I have noticed that
BVNNotEnrolledAllBranches bvnFeilds = new BVNNotEnrolledAllBranches();
was instantiated out side the foreach. So putting this in the foreach statement will solve the problem. And your problem was only assign values to one object but every row in a grid view is an object by it self.

3 solutions

Solution 3

C#

<pre lang="cs">BVNNotEnrolledAllBranches bvnFeilds = new BVNNotEnrolledAllBranches();

was instantiated out side the foreach. So putting this in the foreach statement will solve the problem.

Posted 17-Apr-15 1:38am

Member 10427298

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Andy Lanng · Accepted Answer · 2015-04-17T01:07:00

You're almost there.

bvnFeilds (bvnFields?) is not re-instantiated within the loop. You have one single instance that gets rewritten every loop. I have corrected below

C#

 using (OracleConnection connection = new OracleConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString))
                {
                    DataTable dt = new DataTable();
                    OracleCommand command = new OracleCommand(select, connection);
                    command.CommandTimeout = 900000000;
                    DataSet dataset = new DataSet();
                    OracleDataAdapter adapter = new OracleDataAdapter(command);
                    adapter.Fill(dataset);
                    dt = dataset.Tables[0];
                    List<bvnnotenrolledallbranches> gridRecords = new List<bvnnotenrolledallbranches>();
                    
                    lblNoRecord.Text = "Total record(s): " + dt.Rows.Count.ToString();
                    lblNoRecord.ForeColor = System.Drawing.Color.Green;
                    foreach (System.Data.DataRow dr in dt.Rows)
                    {
                        //Make a new one each pass
                        BVNNotEnrolledAllBranches bvnFeilds = new BVNNotEnrolledAllBranches();
                        //TransactionModel txn = new TransactionModel();
                        bvnFeilds.CustomerName = (dr["Customer_name"].ToString());
                        bvnFeilds.AccountNumber = (dr["Account_number"].ToString());
                        bvnFeilds.CIF = (dr["CIF_ID"].ToString());
                        bvnFeilds.PhoneNumber = (dr["Phone_Number"].ToString());
                        bvnFeilds.BranchName = (dr["BRANCH_NAME"].ToString());
                        bvnFeilds.BVN = (dr["BVN"].ToString());
                        bvnFeilds.Email = (dr["Email"].ToString());
                        //bvnFeilds.Status = (dr["Status"].ToString());

                        gridRecords.Add(bvnFeilds);
                    }
 
                    GridView1.DataSource = gridRecords;
                    GridView1.DataBind();
                }
</bvnnotenrolledallbranches></bvnnotenrolledallbranches>

Suvendu Shekhar Giri · Accepted Answer · 2015-04-17T01:08:00

Solution 2

Initialize bvnFeilds inside the loop.

C#

foreach (System.Data.DataRow dr in dt.Rows)
{
   bvnFeilds = new BVNNotEnrolledAllBranches();

That's all !

Hope, it helps :)

Posted 17-Apr-15 1:08am

Suvendu Shekhar Giri

Updated 17-Apr-15 1:09am

v2

Comments

Uwakpeter 17-Apr-15 7:23am

Thanks Suvendu, it helps!

Suvendu Shekhar Giri 17-Apr-15 7:29am

Glad that it helped :)