Re: enums - C# Discussion Boards

6-Jan-15 21:21

for example i have

[System.Flags]
public enum PrescriptionTypePrint
{
  PrescriptionOnly = 1,
  InstructionOnly = 2,
  Both = PrescriptionOnly | InstructionOnly
}

how i could make it simplify replacing the || to | on the code below

PrescriptionTypePrint pp = PrescriptionTypePrint.Both;

if (pp == PrescriptionTypePrint.PrescriptionOnly || pp == PrescriptionTypePrint.Both)
{
  //execute this block
}

becuase i think this would not work

if (pp == (PrescriptionTypePrint.PrescriptionOnly | PrescriptionTypePrint.Both))
{
  //execute this block
}
// the goal of this if pp has a value of prescription or both it will execute.

thank you so much for the some one who shed me some light

V.6-Jan-15 21:46

6-Jan-15 21:46

I would do this:

[System.Flags]
public enum PrescriptionTypePrint
{
  PrescriptionOnly = 1,
  InstructionOnly = 2,
  //Both = PrescriptionOnly | InstructionOnly
}

and then:

if (pp == (PrescriptionTypePrint.PrescriptionOnly | PrescriptionTypePrint.InstructionOnly))
{
  //execute this block
}

I think that should work.
In any case using "both" as naming convention is a bit confusing. I'm also not sure about the behaviour of the both definition in the enum definition.

V.

(MQOTD rules and previous solutions)

Gilbert Consellado6-Jan-15 22:15

6-Jan-15 22:15

i dont know if using the name "both" is the right name to use,
but it will act as it has the value of "PrescriptionOnly" and "InstructionONly"

OriginalGriff6-Jan-15 22:49

OriginalGriff

6-Jan-15 22:49

If you think of it in terms of binary:

PrescriptionOnly  =  01
InstructionOnly   =  10
Both              =  11

And you want either PrescriptionOnly or Both:

01 or 11

So, of the four possible states the variable can be in, you want two:

None               00     X
PrescriptionOnly   01     Y
InstructionOnly    10     X
Both               11     Y

So all you have to do is:

if ((pp & PrescriptionTypePrint.PrescriptionOnly) != 0)
   {
   ...

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

lukeer6-Jan-15 22:55

lukeer

6-Jan-15 22:55

Use another binary operator

if( (pp & PrescriptionTypePrint.Both) != 0)
{
    // execute this block
}

This will binary-AND two integer operands. The result will equal zero if the oparands don't share a common bit set to '1'. Therefore 'pp' will not result in the expression to equal zero whenever any one of the bits of 'Both' are set in 'pp'.

Ciao,

luker

OriginalGriff6-Jan-15 23:17

OriginalGriff

6-Jan-15 23:17

Um...that'll also execute it for the InstructionOnly case, won't it?

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

lukeer7-Jan-15 1:41

lukeer

7-Jan-15 1:41

Yep, it will.

Your questioning seems like that's not what you wanted. Looking again at what you wrote, I think that's what you need:

if( ( pp & PrescriptionOnly ) != 0 )
{
    // execute in case of PrescriptionOnly or Both
    //   Since Both sets, among others, the PrescriptionOnly-bit.
}

Ciao,

luker

OriginalGriff7-Jan-15 2:08

OriginalGriff

7-Jan-15 2:08

Um...you mean what the OP wanted?
That is what I had already suggested... Laugh | :laugh:

Bad command or file name. Bad, bad command! Sit! Stay! Staaaay...

lukeer7-Jan-15 20:55

lukeer

7-Jan-15 20:55

Sorry, Griff. Yes, I meant the OP.

And Wow, your answer is exhaustive. I'll give it an up.

Ciao,

luker

Gilbert Consellado9-Jan-15 13:07

9-Jan-15 13:07

opsss, I miss the conversation, sorry i was out for a few days.

By the way THANK YOU SO MUCH for the suggestions, surely I will try it.

BillWoodruff9-Jan-15 15:08

BillWoodruff

9-Jan-15 15:08

A slightly different approach using Exclusive-Or:

[Flags]
enum testEnum
{
    p1 = 1,
    p2 = 2,
    p3 = 3,
    p4 = 4,
    p5 = 5
}

private void TestExOr()
{
    testEnum t1 = testEnum.p3;
    
    testEnum t2 = testEnum.p5;
    
    // true
    bool test1 = t1 == (testEnum.p1 ^ testEnum.p2);
    bool test2 = t2 == (testEnum.p1 ^ testEnum.p4);
    bool test3 = t2 == (testEnum.p0 ^ testEnum.p5);
    
    // false
    bool test4 = t1 == (testEnum.p2 ^ testEnum.p3);
    bool test5 = t2 == (testEnum.p2 ^ testEnum.p3);
    bool test6 = t2 == (testEnum.p5 ^ testEnum.p4);
    bool test7 = t2 == (testEnum.p5 ^ testEnum.p1);

    // is the false result here a deal-breaker ?
    bool test8 = t2 == (testEnum.p5 ^ testEnum.p5);}

«A man will be imprisoned in a room with a door that's unlocked and opens inwards ... as long as it does not occur to him to pull rather than push» Wittgenstein

Gilbert Consellado9-Jan-15 16:34

9-Jan-15 16:34

Thank you so much I will try it.

techker26-Jan-15 12:27

6-Jan-15 12:27

hey guys 2 questions is there a way to make a login to read from file.txt?it is just a demo app..so no security for now.

or can i read a file.txt and fill collectionbase??

Dave Kreskowiak6-Jan-15 14:03

Dave Kreskowiak

6-Jan-15 14:03

techker2 wrote:
make a login to read from file.txt

This makes no sense at all since you cannot make an actual "login" do anything. It's a process that authenticates user credentials, nothing else.

techker2 wrote:
can i read a file.txt and fill collectionbase

Whatever this is...

You need to learn how to ask questions. For instance, start with CONTEXT. What is the environment you're talking about? What are the circumstances where you want to do this stuff? What kind of application are you talking about? ...? ...?

A guide to posting questions on CodeProject

Click this: Asking questions is a skill.
Seriously, do it.

Dave Kreskowiak

techker26-Jan-15 14:29

6-Jan-15 14:29

sorry in C#

just need to have user input a nip to enter main form.(nip stored in file auth.txt

as for the load part i was thinking it would be easyer to search in a collection base the a file.so load file and insert info in collectionbase..

Richard Andrew x646-Jan-15 15:28

Richard Andrew x64

6-Jan-15 15:28

techker2 wrote:
input a nip

What is a "nip?"

techker2 wrote:
search in a collection base

What is a "collection base?"

The difficult we do right away...
...the impossible takes slightly longer.

techker26-Jan-15 15:57

6-Jan-15 15:57

nip= 4 didgit number

CollectionBase for information to be stored..

Pete O'Hanlon6-Jan-15 16:03

Pete O'Hanlon

6-Jan-15 16:03

Do you mean database, or are you talking about an in memory collection? And I think you mean PIN, not nip - PIN = Personal Identification Number.

techker26-Jan-15 16:57

6-Jan-15 16:57

sorry french..

memory collection sounds like it..

Pete O'Hanlon6-Jan-15 18:04

Pete O'Hanlon

6-Jan-15 18:04

Don't be sorry about what your native language is. French is a beautiful language, and is one of the cornerstones of modern English. Rejoice in your native speech. Glory in it.

techker27-Jan-15 0:13

7-Jan-15 0:13

thx.

im still stock on this...

i think i got it.

[code]
StreamWriter log;

if (!File.Exists("auth.txt"))
{
log = new StreamWriter("auth.txt");
}
else
{
log = File.AppendText("auth.txt");
}

log.WriteLine(DateTime.Now);
log.WriteLine(lines);
log.WriteLine();
textBox1Message.AppendText(lines);

log.Close();
[/code]

modified 7-Jan-15 6:29am.

Dave Kreskowiak7-Jan-15 2:21

Dave Kreskowiak

7-Jan-15 2:21

Please tell me this is for a school assignment?

Please tell me this is not a application that's going to be put into production?

You really couldn't pick a more insecure method of storing passwords (pin's) if you tried.

A guide to posting questions on CodeProject

Click this: Asking questions is a skill.
Seriously, do it.

Dave Kreskowiak

techker27-Jan-15 2:28

7-Jan-15 2:28

lol ya..i need to make an ATM machine...lol

i got it going.thx

Dave Kreskowiak7-Jan-15 2:35

Dave Kreskowiak

7-Jan-15 2:35

I thought those requirements sounded familiar, but I had to check because there are those idiots who think this is a viable method of securing a production application in an enterprise environment. Smile | :)

Kind of explains all the corporate credit card hacks, doesn't it...

A guide to posting questions on CodeProject

Click this: Asking questions is a skill.
Seriously, do it.

Dave Kreskowiak

techker27-Jan-15 3:05