C#

randor wrote:

I am trying to make a program similar to powerpoint

Member 10498544 wrote:

catch (Exception ex)
{
throw new Exception(ex.Message, ex);
}

public override bool Validate(Control control, object value)
{
    string err = null;
    if (value == null && !_IsAllowNull)
        err = "Please provided valid number without a decimal point.";
    else if (value.ToString().Contains("."))
		err = "Decimal value is not allowed";
	else if (!value.IsNumber())
		err = "Please provided valid number without a decimal point.";
	else if (value.ToInt() < _minValue || value.ToInt() > _maxValue)
		err = "Value should not be greater than " + _maxValue + " or less than " + _minValue;

	if ( err != null)
		ErrorText = err;
    return err == null;
}

Int32 _minValue = 0;
Int32 _maxValue = 100;
Int32 trialvalue;

private bool checkInt(object val)
{
    string strval = val.ToString();

    if (Int32.TryParse(strval, out trialvalue))
    {
        // you have an integer

        // in range: good to go
        if (trialvalue >= _minValue && trialvalue <= _maxValue) return true;

        // handle out of range error here
        // ErrorText = outOfRangeErrorText; // define this somewhere
        return false;
    }

    // analyze for other errors
    return false;
}

public override bool Validate(Control control, object value)
{
    if (value == null && !_IsAllowNull)
    {
        ErrorText = "Please provided valid number without a decimal point.";
        return false;
    }

    if (value.ToString().Contains("."))
    {
        ErrorText = "Decimal value is not allowed";
        return false;
    }

    if (!value.IsNumber())
    {
        ErrorText = "Please provided valid number without a decimal point.";
        return false;
    }
    if (value.ToInt() < _minValue || value.ToInt() > _maxValue)
    {
        ErrorText = "Value should not be greater than " + _maxValue + " or less than " + _minValue;
        return false;
    }
    return true;
}

if (value is Int32)
{
   // convert to Int32 from object
   int valasInt32 = Convert.ToInt32(val);

   // check for in range and return bool
   return ?
}

if (value is string)
{
   // process string input
   return ?
}

// if you get here 'value is some other Type than String or Int32: try to Convert to Int32 ?

public sealed class ValidateInteger : ValidationRule
{
    private int _maxValue = int.MaxValue;
    private int _minValue = int.MinValue;
    private bool _IsAllowNull;

    public ValidateInteger(bool isAllowNull = false)
    {
        _IsAllowNull = isAllowNull;
    }

    public ValidateInteger(int min, int max, bool isAllowNull = false)
    {
        _maxValue = max;
        _minValue = min;
        _IsAllowNull = isAllowNull;
    }

    public override bool Validate(Control control, object value)
    {
        if (value == null && !_IsAllowNull)
        {
            ErrorText = "Please provided valid number without a decimal point.";
            return false;
        }

        if (value.ToString().Contains("."))
        {
            ErrorText = "Decimal value is not allowed";
            return false;
        }

        if (!value.IsNumber())
        {
            ErrorText = "Please provided valid number without a decimal point.";
            return false;
        }
        if (value.ToInt() < _minValue || value.ToInt() > _maxValue)
        {
            ErrorText = "Value should not be greater than " + _maxValue + " or less than " + _minValue;
            return false;
        }
        return true;
    }
}

dxValidationProviderMain.SetValidationRule(txt_height, new Validators.ValidateInteger(false));

dxValidationProviderMain.Validate()

• the control variable is never used inside the function.
• Is there a reason to pass value as an object? In addition I would never use a keyword (value) as a variable name. (unless the autofill gave it that name of course)
• I never program multiple exit points in a function, often it is harder to debug. Better to set a boolean and return that at the end. (although that's more a matter of taste)
• Keep the { }. It will be easier to add a statement if a modification is needed.
• int.TryParse is a very good function. I also often use Convert.ToInt32, but make sure you know what it returns in case of null values or invalid integer strings/objects. (read MSDN doc)
• In some countries the decimal sign is not a ".", but a komma ",".
• You don't need _minValue or _maxValue you have int.MinValue and int.MaxValue.
• An object variable has an IsNumber() and ToInt() function? (not in version 4.5)

private int _maxValue = int.MaxValue;
            private int _minValue = int.MinValue;
            private bool _IsAllowNull;

            public ValidateInteger(bool isAlloweNull = true)
            {
                _IsAllowNull = isAlloweNull;
            }

            public ValidateInteger(int min, int max, bool isAlloweNull = false)
            {
                _maxValue = max;
                _minValue = min;
                _IsAllowNull = isAlloweNull;
            }