Help (how do I avoid repeating a statement when I need a certain one)? C#

Question

0.00/5 (No votes)

See more:

My professor wants us to mirror this image using loops, decision making statements... etc. The only thing I do not get is how I managed to duplicate the word 'Buzz' under 'BuzzLightYear' when it should not be there at all.

What he wants us to do:
https://i.stack.imgur.com/Vcp77.png[^]

My code:

int variable = 25;
while (variable <= 50)
{
if (variable % 2 == 0 && variable % 3 == 0 && variable % 7 == 0)
{
Console.Write("BuzzLightYear\n");
}
if (variable % 2 == 0)
{
Console.Write("Buzz\n");
}
if (variable % 3 == 0 && variable % 2 != 0 && variable % 7 != 0)
{
Console.Write("Light\n");
}
if (variable % 7 == 0 && variable % 2 != 0 && variable % 3 != 0)
{
Console.Write("Year\n");
}
if (variable % 2 != 0 && variable % 3 != 0 && variable % 7 != 0)
{
Console.WriteLine(variable);
}
++variable;
}
Console.Write("\nPress any key to continue to infinity and beyond...");
Console.ReadKey();

What I have tried:

If anyone would be kind enough to help, thanks!

Posted 13-Nov-20 12:09pm

Allyson Bryant

Updated 14-Nov-20 0:21am

Patrice T

v2

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

BillWoodruff · Answer 1 · 2020-11-13T22:03:00

The only thing I do not get is how I managed to duplicate the word 'Buzz' under 'BuzzLightYear' when it should not be there at all.

if (variable % 2 == 0 && variable % 3 == 0 && variable % 7 == 0)
{
    Console.Write("BuzzLightYear\n");
}
if (variable % 2 == 0)
{
    Console.Write("Buzz\n");
}

When the value is 42, it prints "BuzzLightYear; then, it executes the next test, and, since 42 % 2 == 0, it prints "Buzz." It's doing what you tell it to do !

I wonder if your "professor" is serious in giving you such a code-mess.

Think about how you can (easily) reduce the complexity by:

1. using the fact that every number between 25 and 49 is either odd or even.

I'm not going to write your code for you, but, here's an outline you can start to work with:

int variable = 25;
bool isMod2 = false; 
bool isMod3 = false;

while (variable <= 50)
{
    isMod2 = variable % 2 == 0;
    isMod3 = variable % 3 == 0;

    if (isMod2)
    {
        if (isMod3)
        {

        }
        else
        {
            
        }
    }
    else
    {
        // we know isMod3 is 'true here
        // we know the case of both mod 2 and 3 == true has been handled
    }
}

Think about how you can reduce the number of tests for the "rarest" case, when the variable mod 7 is 0.

Richard MacCutchan · Answer 2 · 2020-11-13T22:37:00

All you need to do is make all the tests after the first one to be alternatives by adding else to the if statements, and replacing the last one with else. That way, only one set of conditions will be executed for each iteration of the loop.

C#

int variable = 25;
while (variable <= 50)
{
    if (variable % 2 == 0 && variable % 3 == 0 && variable % 7 == 0)
    {
        Console.Write("BuzzLightYear\n");
    }
    else if (variable % 2 == 0)
    {
        Console.Write("Buzz\n");
    }
    else if (variable % 3 == 0 && variable % 2 != 0 && variable % 7 != 0)
    {
        Console.Write("Light\n");
    }
    else if (variable % 7 == 0 && variable % 2 != 0 && variable % 3 != 0)
    {
        Console.Write("Year\n");
    }
    else
    {
        Console.WriteLine(variable);
    }
    ++variable;
}
Console.Write("\nPress any key to continue to infinity and beyond...");
Console.ReadKey();

George Swan · Answer 3 · 2020-11-14T00:21:00

First off, analyse the problem. What is going on here? Well the decision about what to print is being made on the relationships between 2,3,7 and a variable. What is the relationship? It is based on whether or not 2,3,7 are factors of the variable, more accurately, it is the pattern of the isFactor status for each of the numbers 2,3,7 with regard to the variable. There are combinations of 3 bool values that determine what is printed, these can be represented by a truth table e.g. true,true,true false,true false etc.

There are various ways of coding this. I would use a method that returns a value tuple(bool,bool,bool)

C#

public static (bool,bool,bool)AreTwoThreeSevenFactors(int target)
        {
            (bool is2, bool is3, bool is7) results;
          ...

Then I would plug the results into a switch statement that returns the answer as a string.

C#

private static string ResultsToString((bool, bool, bool) status,int target)
        {
            return status switch
            {
                (true, true, true) => "BuzzLightYear",
         ...

The whole thing can be coded without a single if statement. Have a go. Tip : use the discard value for the 'Buzz' option (true,_,_)

Patrice T · Answer 4 · 2020-11-13T12:59:00

Quote:
What he wants us to do:
https://i.stack.imgur.com/Vcp77.png

When you ask for help, it is a good idea to explain in what the result is wrong.
Giving a piece of code we can run is a good idea too.
-----
Advice: Learn to indent properly your code, it show its structure and it helps reading and understanding. It also helps spotting structures mistakes.

C#

int variable = 25;
while (variable <= 50)
{
    if (variable % 2 == 0 && variable % 3 == 0 && variable % 7 == 0)
    {
        Console.Write("BuzzLightYear\n");
    }
    if (variable % 2 == 0)
    {
        Console.Write("Buzz\n");
    }
    if (variable % 3 == 0 && variable % 2 != 0 && variable % 7 != 0)
    {
        Console.Write("Light\n");
    }
    if (variable % 7 == 0 && variable % 2 != 0 && variable % 3 != 0)
    {
        Console.Write("Year\n");
    }
    if (variable % 2 != 0 && variable % 3 != 0 && variable % 7 != 0)
    {
        Console.WriteLine(variable);
    }
    ++variable;
}
Console.Write("\nPress any key to continue to infinity and beyond...");
Console.ReadKey();

Indentation style - Wikipedia[^]

Professional programmer's editors have this feature and others ones such as parenthesis matching and syntax highlighting.
Notepad++ Home[^]
ultraedit[^]

Help (how do I avoid repeating a statement when I need a certain one)? C#

4 solutions

Solution 2

Solution 3

Solution 4

Solution 1

Add your solution here

Preview 0