How to fix ambiguous column name 'id' when inner join tables in VB.NET

Question

0.00/5 (No votes)

See more:

SqlStr = "select ROW_NUMBER() OVER (ORDER BY id) AS [Sno],Employees.EmpID,Employees.contactno,Empname as [Employee Name],WorkType,ClientName,SiteName,Siteschedule.TotalHours AS [Total Working Hours] from Siteschedule inner join clients on clients.clientid=Siteschedule.clientid inner join sites on sites.SiteID=Siteschedule.SiteID inner join Employees on Employees.EmpID=Siteschedule.empid where (StartDateValue between " & TxtStartDate.Value.Date.ToOADate & " and " & TxtEndDate.Value.Date.ToOADate & ") " & substring

when innerjoining error is ambigous columnname id

What I have tried:

i have tried one solution but not change same error

Posted 12-Jul-18 8:15am

Member 13268442

Updated 12-Jul-18 9:12am

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Bryian Tan · Answer 1 · 2018-07-12T08:49:00

Based on what posted here. This query is referencing the id column

SQL

select ROW_NUMBER() OVER (ORDER BY id)

The id column could exists in more than one tables

Siteschedule
clients
sites
Employees

To solve this error, you can update the code to use table alias and then update this piece "ORDER BY id" to something like ORDER BY [Table Alias].id

SQL Aliases[^]

By the way, I would also suggest to use Parameterized query
https://www.aspsnippets.com/Articles/Using-Parameterized-queries-to-prevent-SQL-Injection-Attacks-in-SQL-Server.aspx

MadMyche · Answer 2 · 2018-07-12T09:13:00

That error means there is a column ID in multiple tables; and the query does not know which one you want. To fix it, qualify it with the table name.
That said, fix your WHERE clause as it is ripe for SQL Injection; NEVER EVER build an Sql Command using string methods, what you should use are Parameters

C#

// just the WHERE condition of the statement for brevity
SqlStr ="WHERE (StartDateValue BETWEEN @StartDate AND @EndDate)" 
cmd.Parameters.AddWithValue("@StartDate", TxtStartDate.Value.Date.ToOADate);
cmd.Parameters.AddWithValue("@EndDate", TxtEndDate.Value.Date.ToOADate);

How to fix ambiguous column name 'id' when inner join tables in VB.NET

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0