Generating billnumber using GUID

Question

0.00/5 (No votes)

See more:

Hi friends,

Please go through this function and tell me, is this the right way to generate a guid?

VB

Private Function billnumber() As Integer
        Dim num As String = System.Guid.NewGuid().ToString
        Dim charCount As Integer = 0
        For Each c As Char In num
            If Char.IsDigit(c) Then
                billnum += c.ToString()
                charCount += 1

            End If
            If charCount = 6 Then
                Exit For
            End If
        Next
        Return billnum
    End Function

Please point out if I am wrong.

Posted 25-Dec-10 19:28pm

su_ma2010

Updated 25-Dec-10 19:35pm

Sandeep Mewara

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

A.J.Wegierski · Answer 1 · 2010-12-26T22:09:00

You can translate guid into two ulong numbers:

C#

Guid g = Guid.NewGuid();
Byte[] b = g.ToByteArray();
UInt64 u1= BitConverter.ToUInt64(b,0);
UInt64 u2 = BitConverter.ToUInt64(b, 8);
MessageBox.Show(u1.ToString() + u2.ToString());

But those bill numbers are giant and not sorted ... try simply increment and remember your numbers.

Sandeep Mewara · Answer 2 · 2010-12-25T19:42:00

As far as creation of GUID[^] goes, its just:

VB

Dim numGuid As Guid = System.Guid.NewGuid();

Now, this looks ok in your code. But what you have done after that is something you need to explain and look at. It looks like you are just trying to pick numbers from the generated GUID and assign that as bill number. If your intention of doing this was to have a unique bill number always then I am sorry to say so, this implementation/approach is incorrect.

Guid as a whole (with combination of number & string) is unique. Picking only numbers from it will not assure uniqueness.

su_ma2010 · Answer 3 · 2010-12-25T20:09:00

Solution 2

Yes i want a unquie number which i want to use as billnumber...

Posted 25-Dec-10 20:09pm

su_ma2010

Generating billnumber using GUID

3 solutions

Solution 3

Solution 1

Solution 2

Add your solution here

Preview 0