Save as file Dialog box

Question

0.00/5 (No votes)

See more:

I want to move one picture file to another file. The user can give the image name by using a save file dialog box. It works properly for non exists files. But when give an exists name, then ask if you want to replace a file from a message box. Then I select "OK" as the response. But Image didn't move correctly. What's the reason?? I can't imagine.

C#

if (saveFileDialog1.ShowDialog() != DialogResult.Cancel)
                {
                    Saved_File = saveFileDialog1.FileName;
                    imageName = Saved_File;

                    if (pbMergeImagePreview.Image != null)
                        pbMergeImagePreview.Image.Dispose();

                    pbMergeImagePreview.InitialImage = null;

                    if (File.Exists(tempName) && !File.Exists(imageName))
                    {
                       
                        File.Move(tempName, imageName);
                      
                       

                    }
                    else if (File.Exists(tempName) && File.Exists(imageName))
                    {
                        File.Move(tempName, imageName);
                        
                    }

                }

Posted 21-Aug-11 18:11pm

Jeremy Shin Woo

Updated 21-Aug-11 18:14pm

walterhevedeich

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Simon Bang Terkildsen · Answer 1 · 2011-08-21T18:20:00

According to the File.Move documentation[^] an IOException is thrown when the distination file already exists.

You can use File.Copy(source, destination, true)[^] to copy the file to the distination and overwrite any existing file. and then use File.Delete[^] to delete the source/original file

Edit: your if-else-if can be simplified

C#

if (File.Exists(tempName) && !File.Exists(imageName))
{
    File.Move(tempName, imageName);
}
else if (File.Exists(tempName) && File.Exists(imageName))
{
    File.Move(tempName, imageName);
}

==

C#

if (File.Exists(tempName)
    File.Move(tempName, imageName);// this is where  I suggest you do your File.Copy and File.Delete

Ganesan Senthilvel · Answer 2 · 2011-08-21T18:21:00

If you refer MSDN for File.Move method, it says Move method works across disk volumes, and it does not throw an exception if the source and destination are the same.

If you attempt to replace a file by moving a file of the same name into that directory, you get an IOException. You cannot use the Move method to overwrite an existing file.

Hope, it gives the answer/reason to your question.

Ganesan Senthilvel · Answer 3 · 2011-08-21T18:24:00

In fact, if you catch exception in your code, it will give the clear picture to the problem.

C#

if (saveFileDialog1.ShowDialog() != DialogResult.Cancel)
                {
                try
                {
                    Saved_File = saveFileDialog1.FileName;
                    imageName = Saved_File;

                    if (pbMergeImagePreview.Image != null)
                        pbMergeImagePreview.Image.Dispose();

                    pbMergeImagePreview.InitialImage = null;

                    if (File.Exists(tempName) && !File.Exists(imageName))
                    {

                        File.Move(tempName, imageName);



                    }
                    else if (File.Exists(tempName) && File.Exists(imageName))
                    {
                        File.Move(tempName, imageName);

                    }
                }
                catch (IOException ex)
                {
                    Console.Writeline("Error here: " + ex.Message);
                }
                }

Save as file Dialog box

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0