Better Code For This?

Question

0.00/5 (No votes)

See more:

hi here some problem with refreshing grid.its not taking me to second page when i click page2

protected void Search_Click(object sender, ImageClickEventArgs e)
   {


       SearchFacultyPL stPL = new SearchFacultyPL();
       stPL.eSession = ddlSession.SelectedValue;
       stPL.ExamDate = ddlDate.SelectedValue;
       stPL.RoomNo = ddlSemister.SelectedValue;


       SearchFacultyBLL stBLL = new SearchFacultyBLL();
       DataTable dt = new DataTable();
       dt = stBLL.SearchRoomDetails(stPL);

       if (dt.Rows.Count > 0)
       {
          grdTimeTable.DataSource = dt;
           grdTimeTable.DataBind();
       }


       if (connection.State == ConnectionState.Open)
       {
           connection.Close();
       }
       connection.Open();
       SqlCommand cmd5 = new SqlCommand();
       SqlDataReader dr5;
       cmd5.Connection = connection;
       cmd5.CommandText = "select facultycode from fAllotmentTab where RoomNo='" + ddlSemister.SelectedValue + "' and examdate='" + ddlDate.SelectedValue + "' and esession='" + ddlSession.SelectedValue + "'";
       dr5 = cmd5.ExecuteReader();
       //if (dr5.Read())
       //{
       //    labelmsg.Text = "Alloted Faculty : " + dr5.GetValue(0).ToString();
       //}
       //else { labelmsg.Text = "Alloted Faculty : "; }
       labelmsg.Text = (dr5.Read()) ? "Alloted Faculty : " + dr5.GetValue(0).ToString() : "Alloted Faculty : ";

   }
   protected void grdTimeTable_PageIndexChanging(object sender, GridViewPageEventArgs e)
   {
       grdTimeTable.PageIndex = e.NewPageIndex;

       DisplayPage();
   }
   void DisplayPage()
   {
       int CurrentPage = grdTimeTable.PageIndex + 1;
   }

can any one tell me how to bind grid.here m not using in page load..

Posted 6-Mar-12 1:01am

ythisbug

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Rahul Rajat Singh · Answer 1 · 2012-03-06T01:30:00

first

C#

if (connection.State == ConnectionState.Open)
        {
            connection.Close();
        }
        connection.Open();

change to

C#

if (connection.State != ConnectionState.Open)
        {
            connection.Open();
        }

second

SQL

SqlCommand cmd5 = new SqlCommand();
        SqlDataReader dr5;
        cmd5.Connection = connection;
        cmd5.CommandText = "select facultycode from fAllotmentTab where RoomNo='" + ddlSemister.SelectedValue + "' and examdate='" + ddlDate.SelectedValue + "' and esession='" + ddlSession.SelectedValue + "'";

to

C#

string selecttext = "select facultycode from fAllotmentTab where RoomNo=@RoomNo and examdate=@ExamDate and esession=@Session";
SqlCommand cmd5 = new SqlCommand(selecttext, connection);
cmd5.parameters.add("@RoomNo"ddlSemister.SelectedValue);
cmd5.parameters.add("@ExamDate", ddlDate.SelectedValue);
cmd5.parameters.add("@Session", ddlSession.SelectedValue);

There could be more optimizations in code but these things were absolute blunders so i pointed them.