java linked list data insertion at Nth position.Why The function insertN() is not working.?

Question

0.00/5 (No votes)

See more:

class Link{
    public  String val;
    public  Link nextlink;
    public Link(String val) {
        this.val = val;
    }
    public void linkNext(Link l){
        this.nextlink=l;
    }
    public void printlink()
    {
        System.out.print(" "+val);
   }
}
class linkList{
    Link first;
    public static int  count=0;
    public linkList(){
        first=null;
    }
    boolean isEmpty(){
        return first==null;
    }

    public void insertfirst(String str){

        Link next=new Link(str);
       count++;
       next.nextlink=first;
        first=next;
    }
    public void insertN(int pos,String str){
        if(pos<count){

         Link temp=first;
       count++;
       for(int i=0;i<pos-1;i++)
           temp=temp.nextlink;
       Link next=new Link(str);
     
       next=temp.nextlink;
         temp=next;
        }
    }
    public void printList(){
        Link currentLink=first;
      System.out.println("data is:");
        while(currentLink!=null){
            
            currentLink.printlink();
            currentLink=currentLink.nextlink;

    }
        System.out.println("  ");


}
}


public class LinkedList2 {
    public static void main(String[] args) {
        linkList li=new linkList();
        li.insertfirst("neeraj");
        li.insertfirst("rohit");
        li.insertfirst("lalit");
        li.insertfirst("meenu");
        li.printList();
        li.insertfirst("newly");
        li.insertN(9, "newlaay");
        li.printList();
        System.out.println(li.count);
    }

}

Posted 6-Apr-12 10:28am

Member 8792998

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Nagy Vilmos · Answer 1 · 2012-04-11T02:51:00

1. Why public static int count=0;?
That means there is a single count for every instance, remove the static!

2.
Change the access for the member variables to private.

3.
Change method linknext to setNextLink, this is a convention in Java that works well.

4.
insertFirst must use the method setNextLink, as the member varianble cannot be accessed:

Java

public void insertFirst(String str) {
    Link next = new Link(str);
    count++;
    next.setNextLink(first);
    first=next;
}

5.
insertN will not work as planned. Allow the Link class to do the work for you :

Java

class Link
    // stuff

    Link getLink (int position) {
        if (position <= 0 || this.nextlink == null) {
            return this.nextLink;
        }
        else
        {
            return this.nextlink.getLink(position - 1);
        }
    }
}

Then to add after a position:

Java

public void insertAfter(int pos,String str){
    Link previous = this.first.getLink(pos);
    if (previous != null) {
        Link next = previous.getNextLink();
        Link insert = new Link(str);
        previous.setNextLink(insert);
        insert.setNextLink(next);
    }
}

Simple and less code to go wrong.