Incorrect syntax near 'Quantity'.

Question

0.00/5 (No votes)

See more:

C#

DateTime date = DateTime.Parse(DateTime.Now.ToShortDateString());
string dt = date.ToString("MM/dd/yyyy");
string month = date.ToString("MMMM");
float mm=float.Parse(TextBox2.Text);
string df = "select Quantity from Item where Item='" + TextBox1.Text + "'";
SqlCommand dd = new SqlCommand(df,DbConnection.mCon);
SqlDataAdapter dg = new SqlDataAdapter(dd);
DataTable sd = new DataTable();
dg.Fill(sd);
if (sd.Rows.Count > 0)
{
  cc = float.Parse(sd.Rows[0][0].ToString());
}
float nb = cc + mm;
string s11 = "update Item set Item='" + TextBox1.Text + "' Quantity='" + nb + "' Price='" + TextBox3.Text + "' Date='" + dt + "' Month='" + month + "' where Item='" + TextBox1.Text + "' ";
 SqlCommand cmdh = new SqlCommand(s11, DbConnection.mCon);
 cmdh.ExecuteNonQuery();

Table name Item

fieldname Quantity datatype float

Posted 16-Dec-12 23:57pm

ravuravu

Updated 16-Dec-12 23:58pm

__TR__

v2

Add a Solution

Comments

__TR__ 17-Dec-12 6:00am

Try executing the update statement generated by your code in SQL server. You might get an idea on what is wrong.

ravuravu 17-Dec-12 6:00am

error shows in the last line cmdh.executenonquery statement

ravuravu 17-Dec-12 6:03am

i don,t know what is the real problem

jayantbramhankar 17-Dec-12 6:05am

add comma(,) after each column in update query.
update Item set Item='" + TextBox1.Text + "', Quantity='" + nb + "' , ans so

ravuravu 17-Dec-12 6:09am

yes u are correct

ravuravu 17-Dec-12 6:10am

thanks jayantbramhankar and __tr__ for helping me

Richard MacCutchan 17-Dec-12 6:11am

You should not use string concatenation to create SQL commands; you are leaving your system open to SQL injection by spammers and viruses. Use proper parameterized queries.

ravuravu 17-Dec-12 6:34am

how to use parameterised queries pls give me an example mr Richard MacCutchan.
i waiting for your example

5 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Aarti Meswania · Answer 1 · 2012-12-17T00:09:00

Solution 1

in Query you forgot to write comma separator in update fields
see, underlined portion in below code...

C#

string s11 = "update Item set Item='" + TextBox1.Text + "' , Quantity='" + nb + "' ,  Price='" + TextBox3.Text + "' ,  Date='" + dt + "' ,  Month='" + month + "' where Item='" + TextBox1.Text + "' ";
 SqlCommand cmdh = new SqlCommand(s11, DbConnection.mCon);
 cmdh.ExecuteNonQuery();

Happy Coding!
:)

Posted 17-Dec-12 0:09am

Aarti Meswania

Comments

ravuravu 17-Dec-12 6:30am

thanks aarti mam

Aarti Meswania 17-Dec-12 6:51am

welcome! :)
Glad to help you! :)

Krunal Rohit · Answer 2 · 2012-12-17T00:10:00

Solution 2

string s11 = "update Item set Item='" + TextBox1.Text + "', Quantity='" + nb + "', Price='" + TextBox3.Text + "', Date='" + dt + "' Month='" + month + "' where Item='" + TextBox1.Text + "' ";
 SqlCommand cmdh = new SqlCommand(s11, DbConnection.mCon);
 cmdh.ExecuteNonQuery();

Posted 17-Dec-12 0:10am

Krunal Rohit

Comments

ravuravu 17-Dec-12 6:31am

thanks sir

[no name] 17-Dec-12 6:34am

If you're satisfied with the given answer, Accept the Solution :)
-Krunal R.

ravuravu 17-Dec-12 6:47am

ya i accepted and vote it

Rai Pawan · Answer 3 · 2012-12-17T00:13:00

change your statement to:

C#

string s11 = "update Item set Item='" + TextBox1.Text + "', Quantity=" + nb + ", Price='" + TextBox3.Text + "', Date='" + dt + "', Month='" + month + "' where Item='" + TextBox1.Text + "' ";

note that a comma has been inserted between each column, apart from that I think that the quantity column is of type float so you should not be enclosing the value between single quotes, which has been removed in above query. Also check on what is the type of Price columns, since if it is also numeric/float/int type you will need to remove the single quotes from the value like this too:

C#

string s11 = "update Item set Item='" + TextBox1.Text + "', Quantity=" + nb + ", Price=" + TextBox3.Text + ", Date='" + dt + "', Month='" + month + "' where Item='" + TextBox1.Text + "' ";

Regards
Pawan

Member 4148390 · Answer 4 · 2012-12-17T00:15:00

Solution 4

I think you are missing comma in the update SQL query. You should correct like this

SQL

string s11 = "update Item set Item='" + TextBox1.Text + "', Quantity='" + nb + "', Price='" + TextBox3.Text + "', Date='" + dt + "', Month='" + month + "' where Item='" + TextBox1.Text + "' ";

Posted 17-Dec-12 0:15am

Member 4148390

Updated 17-Dec-12 20:15pm

v2

Comments

ravuravu 17-Dec-12 6:32am

thanks

AshishChaudha · Answer 5 · 2012-12-17T20:16:00

you are missing , after the column name, please see below query

SQL

string s11 = "update Item set Item='" + TextBox1.Text + "', Quantity='" + nb + "', Price='" + TextBox3.Text + "', Date='" + dt + "', Month='" + month + "' where Item='" + TextBox1.Text + "' ";

Note: Use parameterised query for security issues.

Incorrect syntax near 'Quantity'.

5 solutions

Solution 1

Solution 2

Solution 3

Solution 4

Solution 5

Add your solution here

Preview 0