Helping With Nest Loop

Question

0.00/5 (No votes)

See more:

I'm trying to re write some of my code to make it a bit neater and a bit more efficient as I have just finished my proof of concept stage but I am struggling with writing the loop for the following bit of code.

VB

    Public Sub PopulateDelay()

'Code to check the settings page to see how many delays are to be loaded To be added in the future
'Code should run in a loop for the number of delays as per the settings page or until all delays are written to Dgvdelays

        'Clear All Rows
        FrmDas.DgvDelays.Rows.Clear()

        Dim ef As New ExcelFile
        ' Load Excel file.
        ef.LoadXls(FrmAdmin.TextBox1.Text)
        ' Select the first worksheet from the file.
        Dim ws As ExcelWorksheet = ef.Worksheets(0)

        Dim item As New DataGridViewRow
        Dim item2 As New DataGridViewRow
        Dim item3 As New DataGridViewRow
        Dim item4 As New DataGridViewRow
        Dim item5 As New DataGridViewRow
        item.CreateCells(FrmDas.DgvDelays)
        With item
            .Cells(1).Value = (ws.Cells("b2").Value.ToString())
            .Cells(2).Value = (ws.Cells("c2").Value.ToString())
            .Cells(3).Value = (ws.Cells("D2").Value.ToString())
            .Cells(4).Value = (ws.Cells("E2").Value.ToString())
            .Cells(5).Value = (ws.Cells("F2").Value.ToString())
        End With
        '---add the row---
        FrmDas.DgvDelays.Rows.Add(item)

        item2.CreateCells(FrmDas.DgvDelays)
        With item2
            .Cells(1).Value = (ws.Cells("b3").Value.ToString())
            .Cells(2).Value = (ws.Cells("c3").Value.ToString())
            .Cells(3).Value = (ws.Cells("D3").Value.ToString())
            .Cells(4).Value = (ws.Cells("E3").Value.ToString())
            .Cells(5).Value = (ws.Cells("F3").Value.ToString())
        End With
        '---add the row---
        FrmDas.DgvDelays.Rows.Add(item2)

        item3.CreateCells(FrmDas.DgvDelays)
        With item3
            .Cells(1).Value = (ws.Cells("b4").Value.ToString())
            .Cells(2).Value = (ws.Cells("c4").Value.ToString())
            .Cells(3).Value = (ws.Cells("D4").Value.ToString())
            .Cells(4).Value = (ws.Cells("E4").Value.ToString())
            .Cells(5).Value = (ws.Cells("F4").Value.ToString())
        End With
        '---add the row---
        FrmDas.DgvDelays.Rows.Add(item3)

        item4.CreateCells(FrmDas.DgvDelays)
        With item4
            .Cells(1).Value = (ws.Cells("b5").Value.ToString())
            .Cells(2).Value = (ws.Cells("c5").Value.ToString())
            .Cells(3).Value = (ws.Cells("D5").Value.ToString())
            .Cells(4).Value = (ws.Cells("E5").Value.ToString())
            .Cells(5).Value = (ws.Cells("F5").Value.ToString())
        End With
        '---add the row---
        FrmDas.DgvDelays.Rows.Add(item4)

        item5.CreateCells(FrmDas.DgvDelays)
        With item5
            .Cells(1).Value = (ws.Cells("b6").Value.ToString())
            .Cells(2).Value = (ws.Cells("c6").Value.ToString())
            .Cells(3).Value = (ws.Cells("D6").Value.ToString())
            .Cells(4).Value = (ws.Cells("E6").Value.ToString())
            .Cells(5).Value = (ws.Cells("F6").Value.ToString())
        End With
        '---add the row---
        FrmDas.DgvDelays.Rows.Add(item5)

    End Sub

Any help would be life saving :)

Thank you.

Posted 7-Jan-13 19:58pm

brzt

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

samu4u · Accepted Answer · 2013-01-07T20:09:00

For i=1 to 5
        Dim item As New DataGridViewRow
        item.CreateCells(FrmDas.DgvDelays)
        With item
            .Cells(1).Value = (ws.Cells("b"+(i+1)).Value.ToString())
            .Cells(2).Value = (ws.Cells("c"+(i+1)).Value.ToString())
            .Cells(3).Value = (ws.Cells("D"+(i+1)).Value.ToString())
            .Cells(4).Value = (ws.Cells("E"+(i+1)).Value.ToString())
            .Cells(5).Value = (ws.Cells("F"+(i+1)).Value.ToString())
        End With
        '---add the row---
        FrmDas.DgvDelays.Rows.Add(item)
End For

Check the syntax for the concatenation of b2,c2 etc

brzt · Accepted Answer · 2013-01-07T21:33:00

VB

For I = 1 To 5
    Dim item As New DataGridViewRow
    item.CreateCells(FrmDas.DgvDelays)
    With item
        .Cells(1).Value = (ws.Cells("b" & (I + 1)).Value.ToString())
        .Cells(2).Value = (ws.Cells("c" & (I + 1)).Value.ToString())
        .Cells(3).Value = (ws.Cells("D" & (I + 1)).Value.ToString())
        .Cells(4).Value = (ws.Cells("E" & (I + 1)).Value.ToString())
        .Cells(5).Value = (ws.Cells("F" & (I + 1)).Value.ToString())
    End With
    '---add the row---
    FrmDas.DgvDelays.Rows.Add(item)
Next

Helping With Nest Loop

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0