How do I fix this morse code?

Question

2.00/5 (1 vote)

See more:

How do I complete this code and/or fix it?

#include "stdio.h"
int main(void) {
printf("This code will make a morse code. Enter lowercase letters");
    switch {
    case 'a':
        return ".-";
    case 'b':
        return "-...";
    case 'c':
        return "-.-.";
    case 'd':
        return "-..";
    case 'e':
        return ".";
    case 'f':
        return "..-.";
    case 'g':
        return "--.";
    case 'h':
        return "....";
    case 'i':
        return "..";
    case 'j':
        return ".---";
    case 'k':
        return "-.-";
    case 'l':
        return ".-..";
    case 'm':
        return "--";
    case 'n':
        return "-.";
    case 'o':
        return "---";
    case 'p':
        return ".--.";
    case 'q':
        return "--.-";
    case 'r':
        return ".-.";
    case 's':
        return "...";
    case 't':
        return "-";
    case 'u':
        return "..-";
    case 'v':
        return "...-";
    case 'w':
        return ".--";
    case 'x':
        return "-..-";
    case 'y':
        return "-.--";
    case 'z':
        return "--..";
    case '1':
        return ".----";
    case '2':
        return "..---";
    case '3':
        return "...--";
    case '4':
        return "....-";
    case '5':
        return ".....";
    case '6':
        return "-....";
    case '7':
        return "--...";
    case '8':
        return "---..";
    case '9':
        return "----.";
    case '0':
        return "-----";
        
    default:
         printf("Found wrong characters");
        exit(0);
    }
  return 0;
}

What I have tried:

I have tried a switch function.

Posted 2-Mar-21 17:37pm

Christopher Tillack

Updated 2-Mar-21 22:32pm

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Rick York · Answer 1 · 2021-03-02T18:18:00

Apparently you didn't take my advice last time. That's OK, I will revise it. You have the basis for a function so you should write one. Here's how it could look :

C++

const char * GetMorseCodeString( int chr )
{
    int chrin = tolower( chr );    // force character to be lower case
    switch( chrin )
    {
    case 'a':
        return ".-";
    case 'b':
        return "-...";
    case 'c':
        return "-.-.";
    case 'd':
        return "-..";
    case 'e':
        return ".";
    case 'f':
        return "..-.";
    case 'g':
        return "--.";
    case 'h':
        return "....";
    case 'i':
        return "..";
    case 'j':
        return ".---";
    case 'k':
        return "-.-";
    case 'l':
        return ".-..";
    case 'm':
        return "--";
    case 'n':
        return "-.";
    case 'o':
        return "---";
    case 'p':
        return ".--.";
    case 'q':
        return "--.-";
    case 'r':
        return ".-.";
    case 's':
        return "...";
    case 't':
        return "-";
    case 'u':
        return "..-";
    case 'v':
        return "...-";
    case 'w':
        return ".--";
    case 'x':
        return "-..-";
    case 'y':
        return "-.--";
    case 'z':
        return "--..";
    case '1':
        return ".----";
    case '2':
        return "..---";
    case '3':
        return "...--";
    case '4':
        return "....-";
    case '5':
        return ".....";
    case '6':
        return "-....";
    case '7':
        return "--...";
    case '8':
        return "---..";
    case '9':
        return "----.";
    case '0':
        return "-----";
    }
    return NULL;    // unrecognized
}

Now all you have to do is call that to get a the code strings for various characters that could come from user input or be read from a file or where ever else you want to obtain data from.

Note the use of the tolower function. That will allow you to accept upper case characters also and you don't have to care which it is.

Richard MacCutchan · Answer 2 · 2021-03-02T22:32:00

Solution 2

Get rid of that awful switch block and use a lookup table:

C++

char* letters[] = { ".-", "-...", "-.-.", "-..", ".",
                    "..-.", "--.", "....", "..", ".---",
                    "-.-", ".-..", "--", "-.", "---",
                    ".--.", "--.-", ".-.", "...", "-",
                    "..-", "...-", ".--", "-..-", "-.--", "--.." };
index = chrin - 'a';
return letters[index];

You just need to add the code for numbers, and a check for an illegal character.

Posted 2-Mar-21 22:32pm

Richard MacCutchan

Comments

[no name] 3-Mar-21 8:04am

Thank you

Rick York 3-Mar-21 11:42am

That was my advice last time too. A simple array of strings would work pretty well. A switch statement can be optimized pretty well with those cases but it is much uglier than it needs to be.

Richard MacCutchan 3-Mar-21 11:53am

I missed your solution to the other question. Oh well, nice to know we think alike.