Problem in button movement

Question

0.00/5 (No votes)

See more:

I have uses SetTimer() function for viewing the movement of buttons but the problem is that it does not show the movement here is the code,what is the problem from this code it moves the button but does not show it's movement.

void CMoveDlg::OnButton1() 
{
	// TODO: Add your control notification handler code here
	
		UINT m_tim=SetTimer(1,10000,NULL);
		Move(m_tim);
}
	

void CMoveDlg::Move(UINT m_tim)
{

//ON PLACE OF BUTTON 3	
m_butn1.MoveWindow(30,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(60,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(80,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(100,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(120,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(140,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(220,260,130,60,true);
Sleep(800);
m_butn1.MoveWindow(300,150,130,60,true);
Sleep(800);
m_butn1.MoveWindow(320,130,130,60,true);
Sleep(800);
m_butn1.MoveWindow(320,125,130,60,true);
Sleep(800);
m_butn1.MoveWindow(320,120,130,60,true);
stop(m_tim);
	
}
void CMoveDlg::OnTimer(UINT nIDEvent) 
{
	// TODO: Add your message handler code here and/or call default
	m_butn1.MoveWindow(30,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(60,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(80,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(100,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(120,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(140,10,130,60,true);
Sleep(800);
m_butn1.MoveWindow(220,260,130,60,true);
Sleep(800);
m_butn1.MoveWindow(300,150,130,60,true);
Sleep(800);
m_butn1.MoveWindow(320,130,130,60,true);
Sleep(800);
m_butn1.MoveWindow(320,125,130,60,true);
Sleep(800);
m_butn1.MoveWindow(320,120,130,60,true);
stop(nIDEvent);
	CDialog::OnTimer(nIDEvent);
}

C#

void CMoveDlg::stop(UINT m_tim)
{
KillTimer(m_tim);
}

Posted 19-Jan-10 23:18pm

amalnama

Updated 20-Jan-10 0:04am

CPallini

v3

Add a Solution

3 solutions

Solution 1

Immediately after you start your timer you call the Move() function which moves the button around, kills the timer, and returns. Chances are that the actual timer never gets to fire, since it is stopped before the first timer event gets sent.

Posted 19-Jan-10 23:31pm

Richard MacCutchan

Solution 2

Instead of putting all the movement code into one block with sleeps in between, the OnTimer function should only move your button for one single step. It means that in the OnTimer function, you will have only one call to MoveWindow (and no sleep at all). You will need to check the current button position and update it. Once you want to stop moving the button, you have to kill the timer.

Posted 19-Jan-10 23:35pm

Cedric Moonen

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2010-01-20T00:25:00

void CMoveDlg::NewMoveParameters()
{
  m_dx = (rand() % 10) - 4;
  m_dy = (rand() % 10) - 4;
  m_step = 0;
  m_stepMax = rand() % 40 + 40;
}
void CMoveDlg::OnButton1() 
{
  // UINT m_tim, INT m_x, m_y, m_dx, m_dy, m_step, m_stepMax are CMoveDig member vars
  m_x = m_y = 150; // button start position
  NewMoveParameters();	
  m_tim = SetTimer(1, 100, NULL);
}
void CMoveDlg::OnTimer(UINT nIDEvent) 
{
  if ( nIDEvent == m_tim)
  {
    if ( m_step == m_stepMax )
      NewMoveParameters();
    m_x += m_dx;
    m_y += m_dy;
    m_butn1.MoveWindow(m_x, m_y,130,60, true);
    m_step++;
  }
  CDialog::OnTimer(nIDEvent);
}