string.replace is not working fine, making the for loop to become infinite.

Question

2.50/5 (2 votes)

See more:

C#

string str = @":*?)";

            char[] invalidCharacters = Path.GetInvalidFileNameChars();

            for (;;)
            {
                int index = str.IndexOfAny(invalidCharacters);
                if (index < 0)
                    break;

                char c4 = str[index];
                string replace = string.Format(@"{0:x4}", (ushort)c4);
                str = str.Replace(c.ToString(), replace);
            }

The for loop is becoming infinite.

Posted 28-Jan-13 23:54pm

srikanth.enigma

Add a Solution

3 solutions

Solution 3

Hi Srikanth,
You should use regex Replace method to replace many instances at once.

See simple example:

C#

using System;
using System.Text.RegularExpressions;

public class Example
{
   public static void Main()
   {
      string input = "This is   text with   far  too   much   " +
                     "whitespace.";
      string pattern = "\\s+";
      string replacement = " ";
      Regex rgx = new Regex(pattern);
      string result = rgx.Replace(input, replacement);

      Console.WriteLine("Original String: {0}", input);
      Console.WriteLine("Replacement String: {0}", result);
   }
}
// The example displays the following output:
//       Original String: This is   text with   far  too   much   whitespace.
//       Replacement String: This is text with far too much whitespace.

Cheers,
Edo

Posted 29-Jan-13 0:54am

Joezer BH

Updated 29-Jan-13 0:58am

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-01-29T00:11:00

Solution 1

Depends - did you define the varaiable c outside the loop? Did you mean to use c4 instead?

C#

char c4 = str[index];
string replace = string.Format(@"{0:x4}", (ushort)c4);
str = str.Replace(c.ToString(), replace);

Becomes:

C#

char c4 = str[index];
string replace = string.Format(@"{0:x4}", (ushort)c4);
str = str.Replace(c4.ToString(), replace);

Posted 29-Jan-13 0:11am

OriginalGriff

Comments

srikanth.enigma 29-Jan-13 6:17am

sorry for wasting u r precious time.

OriginalGriff 29-Jan-13 6:22am

You didn't - sometimes it takes a second pair of eyes to see the obvious - I do it all the time (I read what I wanted to write, not what I actually wrote :laugh:)

Santhosh Kumar Jayaraman · Accepted Answer · 2013-01-29T00:12:00

Solution 2

You have to make changes in the following line.
Instead of c use c4

C#

str = str.Replace(c4.ToString(), replace);

Posted 29-Jan-13 0:12am

Santhosh Kumar Jayaraman

v2

Comments

srikanth.enigma 29-Jan-13 6:17am

sorry for wasting u r precious time.