Problem calculating the factorial of a number?

Question

1.00/5 (2 votes)

See more:

Can anyone help me i need to make a method that will take an argument as an integer and then try to calculate it but it shows an stack Overflow Exception so if the value passes the capacity of the integer it should calculate the number in the long type with recursion method

Posted 6-May-13 12:30pm

PokerFace12

Add a Solution

Comments

PIEBALDconsult 6-May-13 21:05pm

Yeah, recursion is the wrong solution -- unless this is homework, in which case you have to do it yourself.

2 solutions

Solution 1

Use BigInteger instead then:
http://msdn.microsoft.com/en-us/library/system.numerics.biginteger.aspx[^]

Posted 6-May-13 12:47pm

Kenneth Haugland

Comments

PokerFace12 6-May-13 19:01pm

I halve tried this but i don't know how to construct the method with the exception handler

PokerFace12 6-May-13 19:05pm

i have this methods :
public long Factorial_Recursion_Long(ref int n)
{
if (n <= 1)
return 1;
return checked( n * Factorial_Recursion_Long(n - 1));

}
public int Factorial_Recursion_int( ref int n)
{
if (n <= 1)
return 1;
return checked( n * Factorial_Recursion_int(n - 1));

}

Sergey Alexandrovich Kryukov 6-May-13 19:51pm

No, OP's problem is stack overflow; so BigInteger would not help. This is "infinite" recursion. Of course, BigInteger is a great thing, but it's even more important to use recursion properly.
For factorial, recursion is really a bad idea, iterative solution should be used.
—SA

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Sergey Alexandrovich Kryukov · Accepted Answer · 2013-05-06T13:53:00

Solution 2

Bad idea. You should use iterative solution, based on loops. I live the implementation for your home exercise. This is really easy. Recursion is a great thing, but you should think: what to use for what.

—SA

Posted 6-May-13 13:53pm

Sergey Alexandrovich Kryukov