How to handle single quotes in sql

Question

0.00/5 (No votes)

See more:

Hi,

I'm having some confusion for the sql query in vb.net.
Below is the query I placed in the code, but it return no result.
When should use the single quotes and double quotes?
Please help....Thanks in advance.

Dim command As String = "SELECT * from T_TRACKING_" + DropDownListSite.SelectedValue + " where NAME IN ('" + name + "') AND ID IN( " + id + ") ORDER BY TIME"

Posted 17-Jun-13 22:26pm

HL22

Updated 17-Jun-13 22:37pm

Pheonyx

v2

Add a Solution

Comments

CPallini 18-Jun-13 4:37am

Why are you using the IN clause (probably you don't need it)?

2 solutions

Solution 1

I would suggest changing your code to user Parameterized queries.

Try reading the following:
http://www.vistadb.net/tutorials/insertrows-vb.aspx[^]
http://visualbasic.about.com/od/learnvbnet/a/begdbapp9.htm[^]

Once you have had a read of them, if you are unable to convert your current approach to a Paramterized approach come back and ask for some help.

Posted 17-Jun-13 22:37pm

Pheonyx

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2013-06-17T22:39:00

IN requires a list, and a list does not require quotes around it. You may need quotes around each individual item in the list if they are not numeric though:
Bad:

SQL

...NAME IN ('Joe,Mike')...

Good:

SQL

...NAME IN ('Joe','Mike')...

"OK.I get what you mean. Do you have any idea to change the following input to the mentioned sample?
Input: Joe,Mike
Output: 'Joe','Mike'"

There are a number of ways to do it, from the simple "brute-force-and-ignorance" method:

VB

Dim s As String = "joe,Mike"
Dim t As String = "'" & s.Replace(",", "','") & "'"

Which works, but any spaces in the input string may cause problems.
A better method uses Linq methods:

VB

Dim s As String = "joe,Mike"
Dim t As String = String.Join(",", s.Split(","C).[Select](Function(f) "'" & f.Trim() & "'"))