how to compress below javascript code.

Question

1.00/5 (1 vote)

See more:

XML

<div>
        Email:
        <input type="text" name="email" id="txtEmail" onblur="emailform()">
        <label id="lblError1" style="color:red"></label>
    </div>
    <div>
        Name:
        <input type="text" name="email" id="txtName" onblur="nameform()">
        <label id="lblError2" style="color:red"></label>
    </div>

    <script>


 function emailform()
 {
        var x = document.getElementById("txtEmail").value;
            if (x==0) {


                document.getElementById("lblError1").innerHTML = "Enter valid email Address";

            }
            else {
                document.getElementById("lblError1").innerHTML = "";

            }
            }
    function nameform()
{
 var x = document.getElementById("txtName").value;
            if (x==0) {
                 document.getElementById("lblError2").innerHTML = "Enter Name";
            }
            else {

                document.getElementById("lblError2").innerHTML = "";
            }


        }

        </script>

Eleminate redundant code ,with same funtionality

Posted 26-May-14 21:43pm

amanpavanker

Updated 26-May-14 21:46pm

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

**Nirav Prabtani** · Accepted Answer · 2014-05-26T21:50:00

TRY THIS,, :)

JavaScript

function Validate(valueData,errorMsg,lblID) {

          if (valueData != "") {

              document.getElementById(lblID).innerHTML = "";
          }
          else {

              document.getElementById(lblID).innerHTML = errorMsg;

          }

      }

HTML

<div>
      Email:
      <input type="text" name="email" id="txtEmail" onblur="Validate(this.value,'Enter Email','lblError1')">
      <label id="lblError1" style="color:red"></label>
  </div>
  <div>
      Name:
      <input type="text" name="email" id="txtName" onblur="Validate(this.value,'Enter Name','lblError2')">
      <label id="lblError2" style="color:red"></label>
  </div>

You can validate multiple textboxes from only one javascript function after passing three parameters (this.value,'Error Message','ID of Label')

Mitchell J. · Accepted Answer · 2014-05-26T22:01:00

OK. Several things you can do here :-)

1. Learn how to use the ?: operator
2. Don't use brackets around one-line if/else statements
3. Don't create variables simply to use them in if statements. Eg you don't need to create the variable "x"
4. Try to keep empty lines to a mininum.
5. Keep an eye out for refactoring as mentioned in Nirav's answer

That's all pretty much in the Javascript - your HTML is pretty good.
Here's what your code looks like after following the tips above:

XML

<div>
    Email:
    <input type="text" name="email" id="txtEmail" onblur="validate('txtEmail', 'lblError1', 'Enter valid email address')">
    <label id="lblError1" style="color:red"></label>
</div>
<div>
    Name:
    <input type="text" name="email" id="txtName" onblur="validate('txtName', 'lblError2', 'Enter name')">
    <label id="lblError2" style="color:red"></label>
</div>
 
<script>
function validate(element, outputElement, errormessage) {
    document.getElementById(outputElement).innerHTML = document.getElementById(element).value==0) ? errormessage : "";
}
</script>

how to compress below javascript code.

2 solutions

Solution 1

Solution 3

Add your solution here

Preview 0